Discussion:
[Freeipa-devel] [freeipa PR#672][opened] IPA-KDB: use relative path in ipa-certmap config snippet
sumit-bose
2017-03-29 14:34:00 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/672
Author: sumit-bose
Title: #672: IPA-KDB: use relative path in ipa-certmap config snippet
Action: opened

PR body:
"""
Architecture specific paths should be avoided in the global Kerberos
configuration because it is read e.g. by 32bit and 64bit libraries they
are installed in parallel.

Resolves https://pagure.io/freeipa/issue/6833
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/672/head:pr672
git checkout pr672
tiran
2017-03-30 06:15:59 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/672
Title: #672: IPA-KDB: use relative path in ipa-certmap config snippet

tiran commented:
"""
LGTM
module
This tag may have multiple values. Each value is a string of the form modulename:pathname, which causes the shared object located at pathname to be registered as a dynamic module named modulename for the pluggable interface. If pathname is not an absolute path, it will be treated as relative to the plugin_base_dir value from [libdefaults].
plugin_base_dir
If set, determines the base directory where krb5 plugins are located. The default value is the krb5/plugins subdirectory of the krb5 library directory.
@sumit-bose What happens when the shared library is missing? Does 32bit kinit fail or work on a X86_64 system when 32bit ipadb.so is missing?
"""

See the full comment at https://github.com/freeipa/freeipa/pull/672#issuecomment-290312805
abbra
2017-03-30 06:45:58 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/672
Title: #672: IPA-KDB: use relative path in ipa-certmap config snippet

abbra commented:
"""
Post by tiran
@sumit-bose What happens when the shared library is missing? Does 32bit kinit fail or work on a X86_64 system when 32bit ipadb.so is missing?
It is not about kinit. The module is for KDC, not client side. We guarantee it exists because we install it.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/672#issuecomment-290317784
HonzaCholasta
2017-04-05 07:29:26 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/672
Title: #672: IPA-KDB: use relative path in ipa-certmap config snippet

Label: +ack
HonzaCholasta
2017-04-05 07:31:35 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/672
Title: #672: IPA-KDB: use relative path in ipa-certmap config snippet

Label: +pushed
HonzaCholasta
2017-04-05 07:31:38 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/672
Title: #672: IPA-KDB: use relative path in ipa-certmap config snippet

HonzaCholasta commented:
"""
master:

* 6c2772dde52c84024d32533b29e6cbd04c69924a IPA-KDB: use relative path in ipa-certmap config snippet


ipa-4-5:

* fa46a01c37021e7b2b57fd3092383100e39792fb IPA-KDB: use relative path in ipa-certmap config snippet


"""

See the full comment at https://github.com/freeipa/freeipa/pull/672#issuecomment-291778291
HonzaCholasta
2017-04-05 07:31:42 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/672
Author: sumit-bose
Title: #672: IPA-KDB: use relative path in ipa-certmap config snippet
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/672/head:pr672
git checkout pr672

Loading...