[Freeipa-devel] [freeipa PR#596][opened] spec file: support client-only build

[HonzaCholasta]

URL: https://github.com/freeipa/freeipa/pull/596
Author: HonzaCholasta
Title: #596: spec file: support client-only build
Action: opened

PR body:
"""
nspr-devel, nss-devel and openssl-devel are required for client-only build,
move their respective BuildRequires from the server-specific BuildRequires
section to the main BuildRequires section.

Pass --enable-server or --disable-server to ./configure based on the value
of %{ONLY_CLIENT}.

Remove the `make client-check` call from %check, as the client-check target
does not exist anymore. Always call `make check` instead.

Do not package the /usr/share/ipa directory in freeipa-client-common, as it
is not created in client-only build.

https://pagure.io/freeipa/issue/6517
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/596/head:pr596
git checkout pr596

[HonzaCholasta]

URL: https://github.com/freeipa/freeipa/pull/596
Author: HonzaCholasta
Title: #596: spec file: support client-only build
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/596/head:pr596
git checkout pr596

[lslebodn]

URL: https://github.com/freeipa/freeipa/pull/596
Title: #596: spec file: support client-only build

lslebodn commented:
"""
You can also move few dependencies to server only build
```
BuildRequires: libini_config-devel
BuildRequires: cyrus-sasl-devel
```

Check spec file changes in **rejected** PR https://github.com/freeipa/freeipa/pull/494/files

otherwise LGTM

"""

See the full comment at https://github.com/freeipa/freeipa/pull/596#issuecomment-286683090

[tiran]

URL: https://github.com/freeipa/freeipa/pull/596
Title: #596: spec file: support client-only build

tiran commented:
"""
```ipa-getkeytab``` uses ```libini_config``` and ```libsasl2```.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/596#issuecomment-286687873

[HonzaCholasta]

URL: https://github.com/freeipa/freeipa/pull/596
Title: #596: spec file: support client-only build

HonzaCholasta commented:
"""
I can't, both are required to build client components (`ipa-getkeytab` specifically), moving them to the server section would break client-only RPM build.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/596#issuecomment-286687860

[pvomacka]

URL: https://github.com/freeipa/freeipa/pull/596
Title: #596: spec file: support client-only build

pvomacka commented:
"""
Client only build does not work on Fedora. So NACK.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/596#issuecomment-286692657

[lslebodn]

URL: https://github.com/freeipa/freeipa/pull/596
Title: #596: spec file: support client-only build

lslebodn commented:
"""

Post by HonzaCholasta
I can't, both are required to build client components (`ipa-getkeytab` specifically), moving them to the server section would break client-only RPM build.

Sorry for confusion. I misinterpreted changes in diff.

The real change was moving following part to server only build
```
# %{_unitdir}, %{_tmpfilesdir}
BuildRequires: systemd
# systemd-tmpfiles which is executed from make install requires apache user
BuildRequires: httpd
```

But git diff decided to show moving of other lines

LS

"""

See the full comment at https://github.com/freeipa/freeipa/pull/596#issuecomment-286694086

[HonzaCholasta]

URL: https://github.com/freeipa/freeipa/pull/596
Author: HonzaCholasta
Title: #596: spec file: support client-only build
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/596/head:pr596
git checkout pr596

[HonzaCholasta]

URL: https://github.com/freeipa/freeipa/pull/596
Author: HonzaCholasta
Title: #596: spec file: support client-only build
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/596/head:pr596
git checkout pr596

[HonzaCholasta]

URL: https://github.com/freeipa/freeipa/pull/596
Title: #596: spec file: support client-only build

HonzaCholasta commented:
"""
This PR now depends on PR #597.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/596#issuecomment-286715408

[HonzaCholasta]

URL: https://github.com/freeipa/freeipa/pull/596
Author: HonzaCholasta
Title: #596: spec file: support client-only build
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/596/head:pr596
git checkout pr596

[HonzaCholasta]

URL: https://github.com/freeipa/freeipa/pull/596
Author: HonzaCholasta
Title: #596: spec file: support client-only build
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/596/head:pr596
git checkout pr596

[pvomacka]

URL: https://github.com/freeipa/freeipa/pull/596
Title: #596: spec file: support client-only build

pvomacka commented:
"""
@HonzaCholasta Thank you for update - only client build on Fedora now works. So ACK once the travis pass.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/596#issuecomment-286720580

[pvomacka]

URL: https://github.com/freeipa/freeipa/pull/596
Title: #596: spec file: support client-only build

pvomacka commented:
"""
ipa server build without tests does not work, so NACK
"""

See the full comment at https://github.com/freeipa/freeipa/pull/596#issuecomment-286728170

[HonzaCholasta]

URL: https://github.com/freeipa/freeipa/pull/596
Author: HonzaCholasta
Title: #596: spec file: support client-only build
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/596/head:pr596
git checkout pr596

[HonzaCholasta]

URL: https://github.com/freeipa/freeipa/pull/596
Title: #596: spec file: support client-only build

HonzaCholasta commented:
"""
Now that PR #502 was pushed this should finally work.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/596#issuecomment-286729368

[pvomacka]

URL: https://github.com/freeipa/freeipa/pull/596
Title: #596: spec file: support client-only build

Label: +ack

[HonzaCholasta]

URL: https://github.com/freeipa/freeipa/pull/596
Title: #596: spec file: support client-only build

HonzaCholasta commented:
"""
master:

* 417f1926c48b426b34b18edb28869f4f06824873 spec file: support client-only build
"""

See the full comment at https://github.com/freeipa/freeipa/pull/596#issuecomment-286742894

[HonzaCholasta]

URL: https://github.com/freeipa/freeipa/pull/596
Title: #596: spec file: support client-only build

Label: +pushed

[HonzaCholasta]

URL: https://github.com/freeipa/freeipa/pull/596
Author: HonzaCholasta
Title: #596: spec file: support client-only build
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/596/head:pr596
git checkout pr596

[HonzaCholasta]

URL: https://github.com/freeipa/freeipa/pull/596
Author: HonzaCholasta
Title: #596: spec file: support client-only build
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/596/head:pr596
git checkout pr596