Discussion:
[Freeipa-devel] [freeipa PR#600][comment] CONFIGURE: Improve detection of xmlrpc_c flags
lslebodn
2017-03-15 12:57:39 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/600
Title: #600: CONFIGURE: Improve detection of xmlrpc_c flags

lslebodn commented:
"""
@tjaalton It should simplify you work on debian
"""

See the full comment at https://github.com/freeipa/freeipa/pull/600#issuecomment-286733233
abbra
2017-03-15 13:08:53 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/600
Title: #600: CONFIGURE: Improve detection of xmlrpc_c flags

abbra commented:
"""
LGTM. Falling back to a standard check is fine.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/600#issuecomment-286735880
MartinBasti
2017-03-15 14:08:05 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/600
Title: #600: CONFIGURE: Improve detection of xmlrpc_c flags

MartinBasti commented:
"""
Could you add ticket to commit message please https://fedorahosted.org/freeipa/ticket/6418

"""

See the full comment at https://github.com/freeipa/freeipa/pull/600#issuecomment-286752024
tjaalton
2017-03-15 14:25:02 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/600
Title: #600: CONFIGURE: Improve detection of xmlrpc_c flags

tjaalton commented:
"""
yes, I just added a comment on the old PR, I need this on Debian, so +1 from me
"""

See the full comment at https://github.com/freeipa/freeipa/pull/600#issuecomment-286757315
MartinBasti
2017-03-15 15:14:58 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/600
Title: #600: CONFIGURE: Improve detection of xmlrpc_c flags

MartinBasti commented:
"""
Commit message amended before pushed
"""

See the full comment at https://github.com/freeipa/freeipa/pull/600#issuecomment-286773684
MartinBasti
2017-03-15 15:15:02 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/600
Title: #600: CONFIGURE: Improve detection of xmlrpc_c flags

Label: +ack
MartinBasti
2017-03-15 15:15:13 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/600
Author: lslebodn
Title: #600: CONFIGURE: Improve detection of xmlrpc_c flags
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/600/head:pr600
git checkout pr600
MartinBasti
2017-03-15 15:15:15 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/600
Title: #600: CONFIGURE: Improve detection of xmlrpc_c flags

MartinBasti commented:
"""
master:

* 2a4f7f2cfaf6ac5ffaf4cc2b43fa0e9b5fa3ebe4 CONFIGURE: Improve detection of xmlrpc_c flags

"""

See the full comment at https://github.com/freeipa/freeipa/pull/600#issuecomment-286773777
MartinBasti
2017-03-15 15:15:03 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/600
Title: #600: CONFIGURE: Improve detection of xmlrpc_c flags

Label: +pushed
lslebodn
2017-03-15 15:49:36 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/600
Title: #600: CONFIGURE: Improve detection of xmlrpc_c flags

lslebodn commented:
"""
Post by MartinBasti
Commit message amended before pushed
Thank you; I was busy with other tasks.

LS

"""

See the full comment at https://github.com/freeipa/freeipa/pull/600#issuecomment-286785306
Loading...