[Freeipa-devel] [freeipa PR#724][opened] upgrade: adtrust update_tdo_gidnumber plugin must check if adtrust is…

[flo-renaud]

URL: https://github.com/freeipa/freeipa/pull/724
Author: flo-renaud
Title: #724: upgrade: adtrust update_tdo_gidnumber plugin must check if adtrust is

Action: opened

PR body:
"""

 installed

During upgrade, the plugin update_tdo_gidnumber is launched in order to
add a gidnumber to the Trusted Domain Object.
This plugin should not be run when ad trust is not installed, otherwise an
error message is displayed.

https://pagure.io/freeipa/issue/6881
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/724/head:pr724
git checkout pr724

[abbra]

URL: https://github.com/freeipa/freeipa/pull/724
Title: #724: upgrade: adtrust update_tdo_gidnumber plugin must check if adtrust is


abbra commented:
"""
LGTM
"""

See the full comment at https://github.com/freeipa/freeipa/pull/724#issuecomment-295855495

[abbra]

URL: https://github.com/freeipa/freeipa/pull/724
Title: #724: upgrade: adtrust update_tdo_gidnumber plugin must check if adtrust is


Label: +ack

[Alexander Bokovoy]

Post by flo-renaud
URL: https://github.com/freeipa/freeipa/pull/724
Author: flo-renaud
Title: #724: upgrade: adtrust update_tdo_gidnumber plugin must check if adtrust is…
Action: opened
"""
… installed
During upgrade, the plugin update_tdo_gidnumber is launched in order to
add a gidnumber to the Trusted Domain Object.
This plugin should not be run when ad trust is not installed, otherwise an
error message is displayed.
https://pagure.io/freeipa/issue/6881
"""
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/724/head:pr724
git checkout pr724

I acked this PR on github but it looks like email hook is broken. There
was no patch attached to this email.

[Martin Bašti]

Post by Alexander Bokovoy

Post by flo-renaud
URL: https://github.com/freeipa/freeipa/pull/724
Author: flo-renaud
Title: #724: upgrade: adtrust update_tdo_gidnumber plugin must check if adtrust is…
Action: opened
"""
… installed
During upgrade, the plugin update_tdo_gidnumber is launched in order to
add a gidnumber to the Trusted Domain Object.
This plugin should not be run when ad trust is not installed,
otherwise an
error message is displayed.
https://pagure.io/freeipa/issue/6881
"""
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/724/head:pr724
git checkout pr724

I acked this PR on github but it looks like email hook is broken. There
was no patch attached to this email.

Thanks for reporting this,

it was just temporal issue, github returned 404 instead of patch, but so
far I don't see more errors in logs than this particular one for #724

[freeipagithubconsumer ERROR]: Cannot download patch:
https://github.com/freeipa/freeipa/pull/724.patch
...
HTTPError: HTTP Error 404: Not Found

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/724
Title: #724: upgrade: adtrust update_tdo_gidnumber plugin must check if adtrust is


Label: +pushed

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/724
Title: #724: upgrade: adtrust update_tdo_gidnumber plugin must check if adtrust is


MartinBasti commented:
"""
master:

* 434d9e539d24fe0110c5d6bf4a4342daf40d15d5 upgrade: adtrust update_tdo_gidnumber plugin must check if adtrust is installed


ipa-4-5:

* c05bd60585fb80e061b8582a648a65204c709f51 upgrade: adtrust update_tdo_gidnumber plugin must check if adtrust is installed


"""

See the full comment at https://github.com/freeipa/freeipa/pull/724#issuecomment-296617979

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/724
Author: flo-renaud
Title: #724: upgrade: adtrust update_tdo_gidnumber plugin must check if adtrust is

Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/724/head:pr724
git checkout pr724