[Freeipa-devel] [freeipa PR#626][opened] Move helper code for integration plugin

[tiran]

URL: https://github.com/freeipa/freeipa/pull/626
Author: tiran
Title: #626: Move helper code for integration plugin
Action: opened

PR body:
"""
Helper code for ```ipatests.pytest_plugins.integration``` was in ```ipatests.test_integration```. This doesn't play nice with pytests auto-discovery of test cases. Certain aspects of pytest are not available right away. For example ```pytest.config``` is generated after configuration stage but before discovery stage.

Now all helper code is next to the plugin in ```ipatests.pytest_plugins.integration``` (which is now a package).
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/626/head:pr626
git checkout pr626

[pvoborni]

URL: https://github.com/freeipa/freeipa/pull/626
Title: #626: Move helper code for integration plugin

pvoborni commented:
"""
From the PR description it is not clear what problem it solves or if it solves a problem.
"doesn't play nice " is vague.

" Certain aspects of pytest are not available right away. For example pytest.config is generated after configuration stage but before discovery stage." Is a description of reality, not a problem.

In other word. Why is this needed? And I'm not implying it is not needed, just the PR comment doesn't explain it.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/626#issuecomment-287730758

[tiran]

URL: https://github.com/freeipa/freeipa/pull/626
Author: tiran
Title: #626: Move helper code for integration plugin
Action: edited

Changed field: body
Original value:
"""
Helper code for ```ipatests.pytest_plugins.integration``` was in ```ipatests.test_integration```. This doesn't play nice with pytests auto-discovery of test cases. Certain aspects of pytest are not available right away. For example ```pytest.config``` is generated after configuration stage but before discovery stage.

Now all helper code is next to the plugin in ```ipatests.pytest_plugins.integration``` (which is now a package).
"""

[tiran]

URL: https://github.com/freeipa/freeipa/pull/626
Author: tiran
Title: #626: Move helper code for integration plugin
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/626/head:pr626
git checkout pr626

[tiran]

URL: https://github.com/freeipa/freeipa/pull/626
Author: tiran
Title: #626: Move helper code for integration plugin
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/626/head:pr626
git checkout pr626

[apophys]

URL: https://github.com/freeipa/freeipa/pull/626
Title: #626: Move helper code for integration plugin

apophys commented:
"""
Thanks for the update
"""

See the full comment at https://github.com/freeipa/freeipa/pull/626#issuecomment-288140640

[apophys]

URL: https://github.com/freeipa/freeipa/pull/626
Title: #626: Move helper code for integration plugin

Label: +ack

[tiran]

URL: https://github.com/freeipa/freeipa/pull/626
Title: #626: Move helper code for integration plugin

tiran commented:
"""
@apophys Please create a ticket for the issue. This PR should not get merged until the issue is properly documented in a ticket and commit messages have been updated.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/626#issuecomment-288354291

[apophys]

URL: https://github.com/freeipa/freeipa/pull/626
Title: #626: Move helper code for integration plugin

apophys commented:
"""
will do
"""

See the full comment at https://github.com/freeipa/freeipa/pull/626#issuecomment-288355769

[tiran]

URL: https://github.com/freeipa/freeipa/pull/626
Title: #626: Move helper code for integration plugin

tiran commented:
"""
@apophys has created ticket https://pagure.io/freeipa/issue/6798 and I have updated all commit messages.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/626#issuecomment-288359861

[tiran]

URL: https://github.com/freeipa/freeipa/pull/626
Author: tiran
Title: #626: Move helper code for integration plugin
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/626/head:pr626
git checkout pr626

[tiran]

URL: https://github.com/freeipa/freeipa/pull/626
Author: tiran
Title: #626: Move helper code for integration plugin
Action: edited

Changed field: body
Original value:
"""
fd1b4f6ec9a349196d5df510008c4745f0b1fb84 broke integration tests because the integration helper imports code from ``ipatests.test_integration```.

```
Traceback (most recent call last):
File "/usr/bin/ipa-test-config", line 30, in <module>
from ipatests.test_integration import config, env_config
File "/usr/lib/python2.7/site-packages/ipatests/test_integration/__init__.py", line 22, in <module>
if pytest.config.getoption('ipaclient_unittests', False):
AttributeError: 'module' object has no attribute 'config'
```

Helper code for ```ipatests.pytest_plugins.integration``` was in ```ipatests.test_integration```. This doesn't play nice with pytests auto-discovery of test cases. Certain aspects of pytest are not available right away. For example ```pytest.config``` is generated after configuration stage but before discovery stage.

Now all helper code is next to the plugin in ```ipatests.pytest_plugins.integration``` (which is now a package).
"""

[tomaskrizek]

URL: https://github.com/freeipa/freeipa/pull/626
Title: #626: Move helper code for integration plugin

Label: +pushed

[tomaskrizek]

URL: https://github.com/freeipa/freeipa/pull/626
Title: #626: Move helper code for integration plugin

tomaskrizek commented:
"""
master:

* dde71ec4a9669a155456a8e8912ed3a0503b8704 Move helper code for integration plugin
* 2895e3931d0b4a9e20e1b211ef5a76f79fc73c9d Move config module to ipatests.pytest_plugins.integration.config
* 1406dbc8c223ac0894088146bfe2a8ef0688097a Move env_config module to ipatests.pytest_plugins.integration.env_config
* 313ae46b573b4cac1075dc1b5bd7294424fabfdb Move tasks module to ipatests.pytest_plugins.integration.tasks
* 8867412adc0ffd0cacf555a5c3693e04074fed5b Move hosts module to ipatests.pytest_plugins.integration.hosts
* 8aadd55c93a627e88e007d2df864a5fb72fba0a2 Move function run_repeatedly to tasks module
* 5587a37e2345de4e76813e00f4b2751d24c618fc Ship ipatests.pytest_plugins.integration
* 24161a619049e0fb3b954592f64ee6d561320d2c Move remaining util functions to tasks module
ipa-4-5:

* 1199416d4e2dd1a653a7c1255e446970412fe1d6 Move helper code for integration plugin
* 025a19c3bf2b446de5c9430142e75eac5887fb04 Move config module to ipatests.pytest_plugins.integration.config
* e257bbd805b319ed85e5bf8ce6eeac80e7c4139c Move env_config module to ipatests.pytest_plugins.integration.env_config
* 321437cc72b38bc055c74f0a4bdf54520afb57aa Move tasks module to ipatests.pytest_plugins.integration.tasks
* 6789dac7a09706036dd13555b4ff2ce244551bc6 Move hosts module to ipatests.pytest_plugins.integration.hosts
* 4c62c4138c443f78757bd519fad143729af27e53 Move function run_repeatedly to tasks module
* 87b60f3cfb5e43fa0c37a09051872b496ad72829 Ship ipatests.pytest_plugins.integration
* cd791843da478625f51e98c502b65e186373a9fa Move remaining util functions to tasks module
"""

See the full comment at https://github.com/freeipa/freeipa/pull/626#issuecomment-288386760

[tomaskrizek]

URL: https://github.com/freeipa/freeipa/pull/626
Author: tiran
Title: #626: Move helper code for integration plugin
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/626/head:pr626
git checkout pr626