Discussion:
[Freeipa-devel] [freeipa PR#748][opened] restore: restart/reload gssproxy after restore
pvoborni
2017-04-28 10:14:16 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/748
Author: pvoborni
Title: #748: restore: restart/reload gssproxy after restore
Action: opened

PR body:
"""
So that gssproxy picks up new configuration and therefore related
usages like authentication of CLI against server works

https://pagure.io/freeipa/issue/6902
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/748/head:pr748
git checkout pr748
pvoborni
2017-04-28 10:14:46 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/748
Title: #748: restore: restart/reload gssproxy after restore

pvoborni commented:
"""
Obsoletes PR #738
"""

See the full comment at https://github.com/freeipa/freeipa/pull/748#issuecomment-297962322
tomaskrizek
2017-04-28 12:01:36 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/748
Title: #748: restore: restart/reload gssproxy after restore

tomaskrizek commented:
"""
How is this patch going to work for Debian? Shouldn't we also implement `reload_or_restart` for `DebianSysvService`?
"""

See the full comment at https://github.com/freeipa/freeipa/pull/748#issuecomment-297980381
pvoborni
2017-04-28 12:39:41 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/748
Title: #748: restore: restart/reload gssproxy after restore

pvoborni commented:
"""
Should work:

```
def debian_service_class_factory(name, api=None):
if name == 'dirsrv':
return redhat_services.RedHatDirectoryService(name, api)
if name == 'domainname':
return DebianNoService(name, api)
if name == 'ipa':
return redhat_services.RedHatIPAService(name, api)
if name == 'messagebus':
return DebianNoService(name, api)
if name == 'ntpd':
return DebianSysvService("ntp", api)
return DebianService(name, api)
```
so it's `DebianService`

```
class DebianService(redhat_services.RedHatService):
system_units = debian_system_units
```
then
```
class RedHatService(base_services.SystemdService):
```

I.e. it is not `DebianSysvService`
"""

See the full comment at https://github.com/freeipa/freeipa/pull/748#issuecomment-297987349
tomaskrizek
2017-04-28 12:53:40 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/748
Title: #748: restore: restart/reload gssproxy after restore

tomaskrizek commented:
"""
Ok, everything looks good then.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/748#issuecomment-297990127
tomaskrizek
2017-04-28 12:53:46 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/748
Title: #748: restore: restart/reload gssproxy after restore

Label: +ack
tomaskrizek
2017-04-28 12:56:49 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/748
Title: #748: restore: restart/reload gssproxy after restore

Label: +pushed
tomaskrizek
2017-04-28 12:56:52 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/748
Title: #748: restore: restart/reload gssproxy after restore

tomaskrizek commented:
"""
master:

* 3a4c8e39c3e38ec651cfcbb3cac59e0e92e04fe0 restore: restart/reload gssproxy after restore


ipa-4-5:

* 04ed1fa3acdf002ecc37dde4f5d226c0fbe5aa30 restore: restart/reload gssproxy after restore


"""

See the full comment at https://github.com/freeipa/freeipa/pull/748#issuecomment-297990747
tomaskrizek
2017-04-28 12:56:54 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/748
Author: pvoborni
Title: #748: restore: restart/reload gssproxy after restore
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/748/head:pr748
git checkout pr748

Loading...