[Freeipa-devel] [freeipa PR#117][opened] Make ipa-replica-install run in interactive mode

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/117
Author: stlaz
Title: #117: Make ipa-replica-install run in interactive mode
Action: opened

PR body:
"""
ipa-replica-install would not run in interactive mode which confused some users. Make it run ipa-client-install in attended mode so that the required arguments are asked for instead of the installation just failing.
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/117/head:pr117
git checkout pr117

[tomaskrizek]

URL: https://github.com/freeipa/freeipa/pull/117
Title: #117: Make ipa-replica-install run in interactive mode

tomaskrizek commented:
"""
NACK, please see inline comments.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/117#issuecomment-249814914

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/117
Author: stlaz
Title: #117: Make ipa-replica-install run in interactive mode
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/117/head:pr117
git checkout pr117

[tomaskrizek]

URL: https://github.com/freeipa/freeipa/pull/117
Title: #117: Make ipa-replica-install run in interactive mode

tomaskrizek commented:
"""
ACK

Running the command in interactive mode by default is desirable behaviour. Since the `-U` flag was present in previous versions, we don't have to worry about backward compatibility.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/117#issuecomment-250389651

[tomaskrizek]

URL: https://github.com/freeipa/freeipa/pull/117
Title: #117: Make ipa-replica-install run in interactive mode

Label: +ack

[jcholast]

URL: https://github.com/freeipa/freeipa/pull/117
Title: #117: Make ipa-replica-install run in interactive mode

Label: -ack

[jcholast]

URL: https://github.com/freeipa/freeipa/pull/117
Title: #117: Make ipa-replica-install run in interactive mode

jcholast commented:
"""
NACK, see inline comments.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/117#issuecomment-251044036

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/117
Author: stlaz
Title: #117: Make ipa-replica-install run in interactive mode
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/117/head:pr117
git checkout pr117

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/117
Author: stlaz
Title: #117: Make ipa-replica-install run in interactive mode
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/117/head:pr117
git checkout pr117

[simo5]

URL: https://github.com/freeipa/freeipa/pull/117
Title: #117: Make ipa-replica-install run in interactive mode

simo5 commented:
"""
@stlaz I do not understand the rationale. Ideally the ipa-replica-install command gathers all necessary info and ipa-client-install is always run in unattended mode.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/117#issuecomment-253868897

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/117
Title: #117: Make ipa-replica-install run in interactive mode

stlaz commented:
"""
@simo5: There is a LOT of checking of various combinations of options in ipa-client-install, not even mentioning IPADiscovery in interactive mode. It does not make sense to copy-paste all/most of it.
Note that this patch may be obsoleted by the installers refactoring effort as the ticket was moved to 4.5 release.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/117#issuecomment-253914584

[simo5]

URL: https://github.com/freeipa/freeipa/pull/117
Title: #117: Make ipa-replica-install run in interactive mode

simo5 commented:
"""
@stlaz, sure, what I meant is that the checking code should be made common and run in ipa-repliuca-install, certainly I was not suggesting to just duplicate all that code. Perhaps refactoring will just do that.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/117#issuecomment-254207783

[tomaskrizek]

URL: https://github.com/freeipa/freeipa/pull/117
Title: #117: Make ipa-replica-install run in interactive mode

tomaskrizek commented:
"""
This PR needs to be rebased to reflect installer refactoring.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/117#issuecomment-262178290

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/117
Author: stlaz
Title: #117: Make ipa-replica-install run in interactive mode
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/117/head:pr117
git checkout pr117

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/117
Title: #117: Make ipa-replica-install run in interactive mode

stlaz commented:
"""
Rebase done. I wanted to wait until some more changes to api bootstrapping to be able to call client installation from module using the latest installer system from the installers refactoring but we agreed with @jcholast that it'd be better to do that later.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/117#issuecomment-267356755

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/117
Title: #117: Make ipa-replica-install run in interactive mode

stlaz commented:
"""
Rebase done. I wanted to wait until some more changes to api bootstrapping to be able to call client installation from module using the latest installer system from the installers refactoring but we agreen with @jcholast that it'd be better to do that later.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/117#issuecomment-267356755

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/117
Title: #117: Make ipa-replica-install run in interactive mode

stlaz commented:
"""
I have a WIP patch but since sometimes it's not clear which credentials are used, I am marking this as postponed so that we can wait until the client module can be called properly.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/117#issuecomment-285683404

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/117
Title: #117: Make ipa-replica-install run in interactive mode

Label: +postponed