Discussion:
[Freeipa-devel] [freeipa PR#735][opened] automount install: do not wait for sssd restart on uninstallation
pvoborni
2017-04-26 13:50:17 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/735
Author: pvoborni
Title: #735: automount install: do not wait for sssd restart on uninstallation
Action: opened

PR body:
"""
Change in 2d4d1a9dc0ef2bbe86751768d6e6b009a52c0dc9 no longer initializes
api in `ipa-client-automount --uninstallation` Which caused error in
wait_for_sssd which gets realm from initialized API.

In my opinion, there is no reason to check working sssd after uninstallation by running
id command. If anything depends on running sssd then it should do the check.

Also fix call of xxx_service_class_factory which requires api as param.

https://pagure.io/freeipa/issue/6861
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/735/head:pr735
git checkout pr735
rcritten
2017-04-26 14:09:28 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/735
Title: #735: automount install: do not wait for sssd restart on uninstallation

rcritten commented:
"""
I guess I have more issues with the commit message than the patch content. What would you suggest ensure that sssd is up? A typical user wouldn't notice until an nss lookup failed which likely means a login was rejected. The wait for restart was there to ensure, in interactive sessions at least, that unconfiguring automount didn't hose the system.

To me is another example of how wrong it is to require a ticket to initialize an API.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/735#issuecomment-297420281
pvoborni
2017-04-26 16:00:45 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/735
Author: pvoborni
Title: #735: automount install: do not wait for sssd restart on uninstallation
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/735/head:pr735
git checkout pr735
pvoborni
2017-04-26 16:03:58 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/735
Author: pvoborni
Title: #735: automount install: do not wait for sssd restart on uninstallation
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/735/head:pr735
git checkout pr735
pvoborni
2017-04-26 16:01:37 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/735
Title: #735: automount install: do not wait for sssd restart on uninstallation

pvoborni commented:
"""
Thanks Rob, this reason for the wait didn't occurred to me. New patch changes api initialization so that it works for both install and uninstall even without user's Kerberos credentials and with cleared cache,
"""

See the full comment at https://github.com/freeipa/freeipa/pull/735#issuecomment-297458891
pvoborni
2017-04-27 07:22:45 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/735
Author: pvoborni
Title: #735: automount install: do not wait for sssd restart on uninstallation
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/735/head:pr735
git checkout pr735
pvoborni
2017-04-27 07:24:49 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/735
Title: #735: automount install: do not wait for sssd restart on uninstallation

pvoborni commented:
"""
The error message was reverted to original (I was fixing the comment below and wondered why it was not fixed, now I know).
"""

See the full comment at https://github.com/freeipa/freeipa/pull/735#issuecomment-297633491
tomaskrizek
2017-04-28 11:21:59 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/735
Title: #735: automount install: do not wait for sssd restart on uninstallation

Label: +ack
MartinBasti
2017-04-28 11:42:47 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/735
Title: #735: automount install: do not wait for sssd restart on uninstallation

MartinBasti commented:
"""
master:

* b4e447fa6fc7d659ae6a3b6285d4ddda0baa0be4 automount install: fix checking of SSSD functionality on uninstall


ipa-4-5:

* ff513d6b20ee0a2ca90b06b8c114386f1e5751d9 automount install: fix checking of SSSD functionality on uninstall


"""

See the full comment at https://github.com/freeipa/freeipa/pull/735#issuecomment-297977040
MartinBasti
2017-04-28 11:42:51 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/735
Author: pvoborni
Title: #735: automount install: do not wait for sssd restart on uninstallation
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/735/head:pr735
git checkout pr735
MartinBasti
2017-04-28 11:42:54 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/735
Title: #735: automount install: do not wait for sssd restart on uninstallation

Label: +pushed

Loading...