Discussion:
[Freeipa-devel] [bind-dyndb-ldap PR#15][opened] ignore what configure and make produced
mingzym
2017-04-07 02:13:33 UTC
Permalink
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/15
Author: mingzym
Title: #15: ignore what configure and make produced
Action: opened

PR body:
"""
let's ignore all the files configure and make created.
"""

To pull the PR as Git branch:
git remote add ghbind-dyndb-ldap https://github.com/freeipa/bind-dyndb-ldap
git fetch ghbind-dyndb-ldap pull/15/head:pr15
git checkout pr15
tomaskrizek
2017-04-07 07:38:54 UTC
Permalink
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/15
Title: #15: ignore what configure and make produced

tomaskrizek commented:
"""
I think the *.lo part is needlessly verbose, since we can ignore all generated files anyway. Could you please change the `make` part to ignore the entire extension instead of the individual files?

```
*.la
*.lo
```
"""

See the full comment at https://github.com/freeipa/bind-dyndb-ldap/pull/15#issuecomment-292464848
mingzym
2017-04-08 14:48:43 UTC
Permalink
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/15
Author: mingzym
Title: #15: ignore what configure and make produced
Action: synchronized

To pull the PR as Git branch:
git remote add ghbind-dyndb-ldap https://github.com/freeipa/bind-dyndb-ldap
git fetch ghbind-dyndb-ldap pull/15/head:pr15
git checkout pr15
mingzym
2017-04-08 14:56:12 UTC
Permalink
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/15
Title: #15: ignore what configure and make produced

mingzym commented:
"""
aha, this is much better now
"""

See the full comment at https://github.com/freeipa/bind-dyndb-ldap/pull/15#issuecomment-292723135
tomaskrizek
2017-04-13 08:54:02 UTC
Permalink
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/15
Title: #15: ignore what configure and make produced

Label: +ack
tomaskrizek
2017-04-13 08:54:21 UTC
Permalink
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/15
Title: #15: ignore what configure and make produced

tomaskrizek commented:
"""
Thanks!

master:
- aadb92bb90f842e89b0465e3c519dbb0d24fec73
"""

See the full comment at https://github.com/freeipa/bind-dyndb-ldap/pull/15#issuecomment-293832066
tomaskrizek
2017-04-13 08:54:22 UTC
Permalink
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/15
Author: mingzym
Title: #15: ignore what configure and make produced
Action: closed

To pull the PR as Git branch:
git remote add ghbind-dyndb-ldap https://github.com/freeipa/bind-dyndb-ldap
git fetch ghbind-dyndb-ldap pull/15/head:pr15
git checkout pr15
tomaskrizek
2017-04-13 08:54:26 UTC
Permalink
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/15
Title: #15: ignore what configure and make produced

Label: +pushed

Loading...