Discussion:
[Freeipa-devel] [freeipa PR#702][opened] Correct PyPI package dependencies
tiran
2017-04-10 08:07:43 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/702
Author: tiran
Title: #702: Correct PyPI package dependencies
Action: opened

PR body:
"""
* Remove unused install requires
* Correct dependencies for yubico otptoken
* Add explicit dependency on cffi for csrgen
* Python 2 uses python-ldap, Python 3 pyldap

Signed-off-by: Christian Heimes <***@redhat.com>

Needs backport to 4.5 for 4.5.1 PyPI packaging.
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/702/head:pr702
git checkout pr702
MartinBasti
2017-04-11 10:45:17 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/702
Title: #702: Correct PyPI package dependencies

MartinBasti commented:
"""
For backport to 4.5 ticket and agreement on ticket triage must be done
"""

See the full comment at https://github.com/freeipa/freeipa/pull/702#issuecomment-293220360
tiran
2017-04-12 15:40:30 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/702
Author: tiran
Title: #702: Correct PyPI package dependencies
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/702/head:pr702
git checkout pr702
tiran
2017-04-13 13:47:35 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/702
Title: #702: Correct PyPI package dependencies

tiran commented:
"""
With recent changes, 4.5 needs a different patch. Let's merge this one and I'll prepare a new one with a ticket another time.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/702#issuecomment-293900251
tiran
2017-04-19 09:15:49 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/702
Author: tiran
Title: #702: Correct PyPI package dependencies
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/702/head:pr702
git checkout pr702
MartinBasti
2017-04-25 10:49:11 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/702
Title: #702: Correct PyPI package dependencies

MartinBasti commented:
"""
Pylint targets are failing with following errror
```
Collecting pyusb; extra == "otptoken_yubikey" (from ipaclient==4.5.90.dev201704251040+git0ebdd30->-c /tmp/freeipa/.wheelconstraints (line 5))
Could not find a version that satisfies the requirement pyusb; extra == "otptoken_yubikey" (from ipaclient==4.5.90.dev201704251040+git0ebdd30->-c /tmp/freeipa/.wheelconstraints (line 5)) (from versions: )
No matching distribution found for pyusb; extra == "otptoken_yubikey" (from ipaclient==4.5.90.dev201704251040+git0ebdd30->-c /tmp/freeipa/.wheelconstraints (line 5))
```
"""

See the full comment at https://github.com/freeipa/freeipa/pull/702#issuecomment-296992860
tiran
2017-04-25 11:18:13 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/702
Author: tiran
Title: #702: Correct PyPI package dependencies
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/702/head:pr702
git checkout pr702
tiran
2017-04-25 11:20:16 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/702
Title: #702: Correct PyPI package dependencies

tiran commented:
"""
You are running into a pip bug. I've added band-aid for the issue. To speed up testing, tox caches packages. I guess I never ran into the problem because I had the packages pre-build and cached.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/702#issuecomment-296999123
MartinBasti
2017-04-26 10:18:54 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/702
Title: #702: Correct PyPI package dependencies

Label: +ack
MartinBasti
2017-04-26 10:32:03 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/702
Title: #702: Correct PyPI package dependencies

Label: +pushed
MartinBasti
2017-04-26 10:32:07 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/702
Title: #702: Correct PyPI package dependencies

MartinBasti commented:
"""
master:

* 26ab51ddf47f421f3404709052db89f08c05adaa Correct PyPI package dependencies
* 994d24d288080e924e039ca0a7b0b0dfc2355ac1 Band-aid for pip dependency bug


"""

See the full comment at https://github.com/freeipa/freeipa/pull/702#issuecomment-297343667
MartinBasti
2017-04-26 10:32:09 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/702
Author: tiran
Title: #702: Correct PyPI package dependencies
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/702/head:pr702
git checkout pr702

Loading...