Discussion:
[Freeipa-devel] [freeipa PR#700][opened] Use entry_points for ipa CLI
tiran
2017-04-07 13:14:35 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/700
Author: tiran
Title: #700: Use entry_points for ipa CLI
Action: opened

PR body:
"""
Fix problem with hard-coded shebang in ipa command line tool by using
a proper setuptools entry point for the console script. ipaclient is now
an executable Python package, too.

```
$ python -m ipaclient ping
```

is equivalent to

```
$ ipa ping
```

Related: https://pagure.io/freeipa/issue/6653
Closes: https://pagure.io/freeipa/issue/6850
Signed-off-by: Christian Heimes <***@redhat.com>
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/700/head:pr700
git checkout pr700
tiran
2017-04-07 13:33:11 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/700
Author: tiran
Title: #700: Use entry_points for ipa CLI
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/700/head:pr700
git checkout pr700
tomaskrizek
2017-04-07 14:12:07 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/700
Title: #700: Use entry_points for ipa CLI

tomaskrizek commented:
"""
Looks good, tested with both rpm and wheels. Ack if the tests pass.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/700#issuecomment-292547332
martbab
2017-04-07 14:31:24 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/700
Title: #700: Use entry_points for ipa CLI

martbab commented:
"""
I wish all of our scripts could be autogenerated from entry points. Long road ahead for that effort. However, this is a good start IMHO.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/700#issuecomment-292552603
tomaskrizek
2017-04-10 06:21:26 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/700
Title: #700: Use entry_points for ipa CLI

Label: +ack
MartinBasti
2017-04-11 11:31:16 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/700
Title: #700: Use entry_points for ipa CLI

Label: +pushed
MartinBasti
2017-04-11 11:31:20 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/700
Title: #700: Use entry_points for ipa CLI

MartinBasti commented:
"""
master:

* bf67974459f093487a1c5a49234769803780ecbe Use entry_points for ipa CLI


ipa-4-5:

* 1e1e4e8ef2d2486068e17228c8a0f8b1a2b099f5 Use entry_points for ipa CLI


"""

See the full comment at https://github.com/freeipa/freeipa/pull/700#issuecomment-293229445
MartinBasti
2017-04-11 11:31:23 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/700
Author: tiran
Title: #700: Use entry_points for ipa CLI
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/700/head:pr700
git checkout pr700

Loading...