Discussion:
[Freeipa-devel] [freeipa PR#688][opened] Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches
redhatrises
2017-04-03 19:12:54 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/688
Author: redhatrises
Title: #688: Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches
Action: opened

PR body:
"""
- Update get_attr_filter in LDAPSearch to handle nsaccountlock by setting nsaccountlock=True if
`ipa user-find --disabled=False` is entered in the command line and then search for any case where nsaccountlock != True. This handles the case where nsaccountlock may not exist as an attribute or is False.
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/688/head:pr688
git checkout pr688
redhatrises
2017-04-05 12:54:51 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/688
Author: redhatrises
Title: #688: Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/688/head:pr688
git checkout pr688
redhatrises
2017-04-05 12:55:38 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/688
Author: redhatrises
Title: #688: Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches
Action: edited

Changed field: body
Original value:
"""
- Update get_attr_filter in LDAPSearch to handle nsaccountlock by setting nsaccountlock=True if
`ipa user-find --disabled=False` is entered in the command line and then search for any case where nsaccountlock != True. This handles the case where nsaccountlock may not exist as an attribute or is False.
"""
redhatrises
2017-04-05 13:26:18 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/688
Author: redhatrises
Title: #688: Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/688/head:pr688
git checkout pr688
redhatrises
2017-04-06 19:57:08 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/688
Title: #688: Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches

redhatrises commented:
"""
@HonzaCholasta ready for your review.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/688#issuecomment-292297176
redhatrises
2017-04-20 12:17:51 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/688
Title: #688: Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches

redhatrises commented:
"""
Bump for review
"""

See the full comment at https://github.com/freeipa/freeipa/pull/688#issuecomment-295713616
redhatrises
2017-04-20 12:18:31 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/688
Title: #688: Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches

redhatrises commented:
"""
Should this also go into the 4.5 branch?
"""

See the full comment at https://github.com/freeipa/freeipa/pull/688#issuecomment-295713837
HonzaCholasta
2017-04-25 06:50:42 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/688
Title: #688: Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches

HonzaCholasta commented:
"""
I guess it should. Could you please file a ticket?
"""

See the full comment at https://github.com/freeipa/freeipa/pull/688#issuecomment-296931927
redhatrises
2017-04-25 13:05:19 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/688
Author: redhatrises
Title: #688: Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches
Action: edited

Changed field: body
Original value:
"""
- Update get_attr_filter in LDAPSearch to handle nsaccountlock by setting the default value for
nsaccountlock to false as well as update the filter to check for the default value
"""
redhatrises
2017-04-25 13:05:28 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/688
Author: redhatrises
Title: #688: Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches
Action: edited

Changed field: body
Original value:
"""
- Update get_attr_filter in LDAPSearch to handle nsaccountlock by setting the default value for
nsaccountlock to false as well as update the filter to check for the default value

https://pagure.io/freeipa/issue/6896
"""
redhatrises
2017-04-25 13:05:44 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/688
Title: #688: Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches

redhatrises commented:
"""
@HonzaCholasta done. https://pagure.io/freeipa/issue/6896
"""

See the full comment at https://github.com/freeipa/freeipa/pull/688#issuecomment-297023523
HonzaCholasta
2017-04-25 13:08:19 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/688
Title: #688: Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches

HonzaCholasta commented:
"""
Thanks!
"""

See the full comment at https://github.com/freeipa/freeipa/pull/688#issuecomment-297024230
HonzaCholasta
2017-04-25 13:09:30 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/688
Title: #688: Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches

Label: +ack
HonzaCholasta
2017-04-25 13:10:54 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/688
Title: #688: Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches

Label: -ack
HonzaCholasta
2017-04-25 13:13:49 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/688
Title: #688: Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches

HonzaCholasta commented:
"""
Actually, please remove the change in `VERSION.m4`, as it is not necessary and prevents the patch from applying cleanly on top of ipa-4-5.

Also please add the ticket link to commit messages.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/688#issuecomment-297025571
redhatrises
2017-04-25 13:53:26 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/688
Author: redhatrises
Title: #688: Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/688/head:pr688
git checkout pr688
redhatrises
2017-04-25 13:54:33 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/688
Title: #688: Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches

redhatrises commented:
"""
@HonzaCholasta I removed the change to `VERSION.m4`
"""

See the full comment at https://github.com/freeipa/freeipa/pull/688#issuecomment-297037487
HonzaCholasta
2017-04-26 10:20:39 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/688
Title: #688: Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches

Label: +ack
HonzaCholasta
2017-04-26 10:21:19 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/688
Title: #688: Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches

Label: +pushed
HonzaCholasta
2017-04-26 10:21:22 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/688
Title: #688: Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches

HonzaCholasta commented:
"""
master:

* 38276d3473ecf2a4cc5b5e2a107347f046625626 Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches


ipa-4-5:

* dc4d60c9665408666ab3dfab7023a578c34d65a2 Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches


"""

See the full comment at https://github.com/freeipa/freeipa/pull/688#issuecomment-297338734
HonzaCholasta
2017-04-26 10:21:23 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/688
Author: redhatrises
Title: #688: Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/688/head:pr688
git checkout pr688

Loading...