[Freeipa-devel] [freeipa PR#582][opened] Remove pkinit from ipa-replica-prepare

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/582
Author: stlaz
Title: #582: Remove pkinit from ipa-replica-prepare
Action: opened

PR body:
"""
The PKINIT feature is not available on domain level 0 so any
options about pkinit are false.

https://pagure.io/freeipa/issue/6759
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/582/head:pr582
git checkout pr582

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/582
Title: #582: Remove pkinit from ipa-replica-prepare

MartinBasti commented:
"""
Works for me. @abbra @simo5 do you have any objections?
"""

See the full comment at https://github.com/freeipa/freeipa/pull/582#issuecomment-286444597

[abbra]

URL: https://github.com/freeipa/freeipa/pull/582
Title: #582: Remove pkinit from ipa-replica-prepare

abbra commented:
"""
LGTM.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/582#issuecomment-286447734

[HonzaCholasta]

URL: https://github.com/freeipa/freeipa/pull/582
Title: #582: Remove pkinit from ipa-replica-prepare

HonzaCholasta commented:
"""
The options were available since forever, so I guess you should just hide them instead of removing them.

The same options are still available in domain level 0 `ipa-server-install` - is this intentional?
"""

See the full comment at https://github.com/freeipa/freeipa/pull/582#issuecomment-286448587

[abbra]

URL: https://github.com/freeipa/freeipa/pull/582
Title: #582: Remove pkinit from ipa-replica-prepare

abbra commented:
"""
They were in DL0 in `ipa-server-install` for very long time and never worked. We left them there to make sure we can get them back to work sometime later. We did but in new design `ipa-replica-prepare` does not need to use these options, unlike `ipa-server-install`.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/582#issuecomment-286449785

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/582
Title: #582: Remove pkinit from ipa-replica-prepare

Label: +ack

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/582
Title: #582: Remove pkinit from ipa-replica-prepare

Label: +pushed

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/582
Author: stlaz
Title: #582: Remove pkinit from ipa-replica-prepare
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/582/head:pr582
git checkout pr582

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/582
Title: #582: Remove pkinit from ipa-replica-prepare

MartinBasti commented:
"""
master:

* 46d4d534c08d14756b989e157e87a078d174ad5c Remove pkinit from ipa-replica-prepare
"""

See the full comment at https://github.com/freeipa/freeipa/pull/582#issuecomment-286776674