Discussion:
[Freeipa-devel] [freeipa PR#676][opened] Use with statement for opening file
Akasurde
2017-03-30 07:59:04 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/676
Author: Akasurde
Title: #676: Use with statement for opening file
Action: opened

PR body:
"""
Signed-off-by: Abhijeet Kasurde <***@redhat.com>
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/676/head:pr676
git checkout pr676
MartinBasti
2017-03-30 08:29:08 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/676
Title: #676: Use with statement for opening file

MartinBasti commented:
"""
LGTM, let's wait for travis
"""

See the full comment at https://github.com/freeipa/freeipa/pull/676#issuecomment-290339708
MartinBasti
2017-03-30 10:00:39 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/676
Title: #676: Use with statement for opening file

Label: +ack
MartinBasti
2017-03-30 11:08:49 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/676
Title: #676: Use with statement for opening file

Label: +pushed
MartinBasti
2017-03-30 11:08:59 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/676
Author: Akasurde
Title: #676: Use with statement for opening file
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/676/head:pr676
git checkout pr676
MartinBasti
2017-03-30 11:08:55 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/676
Title: #676: Use with statement for opening file

MartinBasti commented:
"""
master:

* 6d4c917440793e988b907a62f2f56f5dc82b53dd Use with statement for opening file


"""

See the full comment at https://github.com/freeipa/freeipa/pull/676#issuecomment-290379294
Akasurde
2017-03-30 11:39:03 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/676
Title: #676: Use with statement for opening file

Akasurde commented:
"""
@MartinBasti Thanks.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/676#issuecomment-290385446
Loading...