Discussion:
[Freeipa-devel] [freeipa PR#480][opened] Add request_type doc string in cert-request
Akasurde
2017-02-18 11:09:38 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/480
Author: Akasurde
Title: #480: Add request_type doc string in cert-request
Action: opened

PR body:
"""
Fix adds correct description to request_type argument
in cert-request command help

Fixes https://fedorahosted.org/freeipa/ticket/6494

Signed-off-by: Abhijeet Kasurde <***@redhat.com>
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/480/head:pr480
git checkout pr480
MartinBasti
2017-02-20 11:43:21 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/480
Title: #480: Add request_type doc string in cert-request

MartinBasti commented:
"""
Ticket is `Enumerate all available request type options in ipa cert-request help` but your commit doesn't enumerate all possible certtypes
"""

See the full comment at https://github.com/freeipa/freeipa/pull/480#issuecomment-281058427
MartinBasti
2017-02-20 11:43:41 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/480
Title: #480: Add request_type doc string in cert-request

MartinBasti commented:
"""
Ticket is `Enumerate all available request type options in ipa cert-request help` but your commit doesn't enumerate all possible certtypes
"""

See the full comment at https://github.com/freeipa/freeipa/pull/480#issuecomment-281058427
frasertweedale
2017-02-21 00:00:22 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/480
Title: #480: Add request_type doc string in cert-request

frasertweedale commented:
"""
I would like to NACK this. We instead want to hide or remove the option, because
we only support PKCS #10 and this is unlikely to change any time soon.

There is already a ticket for that: https://fedorahosted.org/freeipa/ticket/5734
"""

See the full comment at https://github.com/freeipa/freeipa/pull/480#issuecomment-281209123
Akasurde
2017-02-21 06:57:48 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/480
Title: #480: Add request_type doc string in cert-request

Akasurde commented:
"""
@frasertweedale What do you recommend to hide this option ? does removing this option has detrimental effect on `cert-request` command ?
"""

See the full comment at https://github.com/freeipa/freeipa/pull/480#issuecomment-281260868
frasertweedale
2017-02-21 11:45:18 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/480
Title: #480: Add request_type doc string in cert-request

frasertweedale commented:
"""
@Akasurde if we just want to hide it, I think you use a client override for the `cert_request` command
and filter out the option. @HonzaCholasta can confirm.

OTOH if we just want to remove it altogether, that is straightforward. It will break any clients that
explicitly pass the option. I suspect it's unlikely that there are such clients out there, but we cannot
know for sure, so as much as I'd like to remove it, I'm hesitant.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/480#issuecomment-281320509
Akasurde
2017-03-15 06:49:07 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/480
Title: #480: Add request_type doc string in cert-request

Akasurde commented:
"""
@HonzaCholasta ping
"""

See the full comment at https://github.com/freeipa/freeipa/pull/480#issuecomment-286655805
HonzaCholasta
2017-03-15 06:56:26 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/480
Title: #480: Add request_type doc string in cert-request

HonzaCholasta commented:
"""
I agree with @frasertweedale, but we can't remove the option from the server plugin altogether, as pre-4.4 clients always send it. You can hide the option by adding the `no_option` flag in the param definition.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/480#issuecomment-286656963
Akasurde
2017-03-15 10:14:36 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/480
Title: #480: Add request_type doc string in cert-request

Akasurde commented:
"""
@HonzaCholasta Thanks I will use `no_option` flag and update PR.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/480#issuecomment-286698411
Akasurde
2017-03-15 10:26:12 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/480
Author: Akasurde
Title: #480: Add request_type doc string in cert-request
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/480/head:pr480
git checkout pr480
Akasurde
2017-03-15 11:08:37 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/480
Author: Akasurde
Title: #480: Add request_type doc string in cert-request
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/480/head:pr480
git checkout pr480
Akasurde
2017-03-15 11:09:00 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/480
Author: Akasurde
Title: #480: Hide request_type doc string in cert-request help
Action: edited

Changed field: title
Original value:
"""
Add request_type doc string in cert-request
"""
Akasurde
2017-03-15 11:09:18 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/480
Author: Akasurde
Title: #480: Hide request_type doc string in cert-request help
Action: edited

Changed field: body
Original value:
"""
Fix adds correct description to request_type argument
in cert-request command help

Fixes https://fedorahosted.org/freeipa/ticket/6494

Signed-off-by: Abhijeet Kasurde <***@redhat.com>
"""
Akasurde
2017-03-30 03:07:21 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/480
Title: #480: Hide request_type doc string in cert-request help

Akasurde commented:
"""
Bump for review.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/480#issuecomment-290289355
MartinBasti
2017-03-30 15:35:15 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/480
Title: #480: Hide request_type doc string in cert-request help

Label: +ack
MartinBasti
2017-03-31 10:33:18 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/480
Title: #480: Hide request_type doc string in cert-request help

Label: +pushed
MartinBasti
2017-03-31 10:33:21 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/480
Title: #480: Hide request_type doc string in cert-request help

MartinBasti commented:
"""
master:

* a1bb442054936113369a88b49483e914664712e7 Hide request_type doc string in cert-request help


ipa-4-5:

* 535e8610c556ab1a0eb83e9798e7e182355d8396 Hide request_type doc string in cert-request help


"""

See the full comment at https://github.com/freeipa/freeipa/pull/480#issuecomment-290678419
MartinBasti
2017-03-31 10:33:24 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/480
Author: Akasurde
Title: #480: Hide request_type doc string in cert-request help
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/480/head:pr480
git checkout pr480
Akasurde
2017-03-31 10:38:53 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/480
Title: #480: Hide request_type doc string in cert-request help

Akasurde commented:
"""
@MartinBasti @frasertweedale @HonzaCholasta Thanks
"""

See the full comment at https://github.com/freeipa/freeipa/pull/480#issuecomment-290679480
MartinBasti
2017-03-31 10:43:39 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/480
Title: #480: Hide request_type doc string in cert-request help

MartinBasti commented:
"""
@Akasurde you are welcome
"""

See the full comment at https://github.com/freeipa/freeipa/pull/480#issuecomment-290680413
Loading...