Discussion:
[Freeipa-devel] [freeipa PR#636][opened] [Py3] Fix ipatests.util doc tests
tiran
2017-03-22 10:51:30 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/636
Author: tiran
Title: #636: [Py3] Fix ipatests.util doc tests
Action: opened

PR body:
"""
Doctests of ipatests.util fail under Python 3.

The old test scenario does no longer work on Python 3 since u'how are you'
and 'how are you' have identical type, but u'how are you' != b'how are you'.
It works with int / float on all Python versions.

Python 2 has <type 'int'> while Python 3 uses <class 'int'>.

Signed-off-by: Christian Heimes <***@redhat.com>
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/636/head:pr636
git checkout pr636
MartinBasti
2017-03-29 17:35:27 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/636
Title: #636: [Py3] Fix ipatests.util doc tests

Label: +ack
MartinBasti
2017-03-30 11:20:38 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/636
Title: #636: [Py3] Fix ipatests.util doc tests

MartinBasti commented:
"""
master:

* 397e6716974f90168792ec0a6ad0b7b37c02eb87 Fix ipatests.util doc tests


"""

See the full comment at https://github.com/freeipa/freeipa/pull/636#issuecomment-290381626
MartinBasti
2017-03-30 11:20:42 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/636
Title: #636: [Py3] Fix ipatests.util doc tests

Label: +pushed
MartinBasti
2017-03-30 11:20:48 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/636
Author: tiran
Title: #636: [Py3] Fix ipatests.util doc tests
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/636/head:pr636
git checkout pr636

Loading...