Discussion:
[Freeipa-devel] [freeipa PR#609][opened] [4.4] Fix cookie with Max-Age processing
stlaz
2017-03-16 15:40:56 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/609
Author: stlaz
Title: #609: [4.4] Fix cookie with Max-Age processing
Action: opened

PR body:
"""
When cookie has Max-Age set it tries to get expiration by adding
to a timestamp. Without this patch the timestamp would be set to
None and thus the addition of timestamp + max_age fails

https://pagure.io/freeipa/issue/6718

Reviewed-By: Simo Sorce <***@redhat.com>
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/609/head:pr609
git checkout pr609
stlaz
2017-03-16 15:41:05 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/609
Author: stlaz
Title: #609: [4.4] Fix cookie with Max-Age processing
Action: edited

Changed field: body
Original value:
"""
When cookie has Max-Age set it tries to get expiration by adding
to a timestamp. Without this patch the timestamp would be set to
None and thus the addition of timestamp + max_age fails

https://pagure.io/freeipa/issue/6718

Reviewed-By: Simo Sorce <***@redhat.com>
"""
stlaz
2017-03-16 15:41:25 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/609
Author: stlaz
Title: #609: [4.4] Fix cookie with Max-Age processing
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/609/head:pr609
git checkout pr609
stlaz
2017-03-17 08:02:10 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/609
Author: stlaz
Title: #609: [4.4] Fix cookie with Max-Age processing
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/609/head:pr609
git checkout pr609
MartinBasti
2017-03-20 15:54:26 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/609
Title: #609: [4.4] Fix cookie with Max-Age processing

Label: +ack
tomaskrizek
2017-03-20 18:11:06 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/609
Title: #609: [4.4] Fix cookie with Max-Age processing

Label: +pushed
tomaskrizek
2017-03-20 18:11:11 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/609
Author: stlaz
Title: #609: [4.4] Fix cookie with Max-Age processing
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/609/head:pr609
git checkout pr609
tomaskrizek
2017-03-20 18:11:14 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/609
Title: #609: [4.4] Fix cookie with Max-Age processing

tomaskrizek commented:
"""
ipa-4-4:

* 40f3b8f8a3d33864528138e517ce3240da6c9a4a Fix cookie with Max-Age processing
* 5caade99127ff46141d2f6b7137f7aa62c0ff3bc Add debug log in case cookie retrieval went wrong
"""

See the full comment at https://github.com/freeipa/freeipa/pull/609#issuecomment-287848903
Loading...