Discussion:
[Freeipa-devel] [freeipa PR#804][synchronized] krb5: make sure KDC certificate is readable
abbra
2017-05-22 19:41:33 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/804
Author: abbra
Title: #804: krb5: make sure KDC certificate is readable
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/804/head:pr804
git checkout pr804
abbra
2017-05-22 19:57:09 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/804
Author: abbra
Title: #804: krb5: make sure KDC certificate is readable
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/804/head:pr804
git checkout pr804
abbra
2017-05-22 19:58:21 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/804
Author: abbra
Title: #804: krb5: make sure KDC certificate is readable
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/804/head:pr804
git checkout pr804
simo5
2017-05-22 20:23:42 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/804
Title: #804: krb5: make sure KDC certificate is readable

Label: +ack
HonzaCholasta
2017-05-23 05:41:00 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/804
Title: #804: krb5: make sure KDC certificate is readable

HonzaCholasta commented:
"""
I have already "solved" this by changing the permissions of the cert file in the `renew_kdc_cert`. Your solution is definitely better, please remove the chmod call from `renew_kdc_cert`.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/804#issuecomment-303295791
HonzaCholasta
2017-05-23 05:38:02 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/804
Title: #804: krb5: make sure KDC certificate is readable

Label: -ack
HonzaCholasta
2017-05-23 05:41:44 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/804
Title: #804: krb5: make sure KDC certificate is readable

HonzaCholasta commented:
"""
I have already "solved" this by changing the permissions of the cert file in the `renew_kdc_cert` restart script. Your solution is definitely better, please remove the chmod call from `renew_kdc_cert`.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/804#issuecomment-303295791
abbra
2017-05-23 06:35:48 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/804
Author: abbra
Title: #804: krb5: make sure KDC certificate is readable
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/804/head:pr804
git checkout pr804
abbra
2017-05-23 06:36:41 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/804
Title: #804: krb5: make sure KDC certificate is readable

abbra commented:
"""
I removed chmod call now. Sorry for not noticing it yesterday. ;)
"""

See the full comment at https://github.com/freeipa/freeipa/pull/804#issuecomment-303303949
HonzaCholasta
2017-05-23 07:19:32 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/804
Title: #804: krb5: make sure KDC certificate is readable

HonzaCholasta commented:
"""
No problem, thank you.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/804#issuecomment-303311812
MartinBasti
2017-05-23 10:35:25 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/804
Title: #804: krb5: make sure KDC certificate is readable

MartinBasti commented:
"""
Please fix pylint errors:
```
************* Module renew_kdc_cert
install/restart_scripts/renew_kdc_cert:6: [W0611(unused-import), ] Unused import os)
install/restart_scripts/renew_kdc_cert:11: [W0611(unused-import), ] Unused paths imported from ipaplatform.paths)
```
"""

See the full comment at https://github.com/freeipa/freeipa/pull/804#issuecomment-303359075
abbra
2017-05-23 11:01:29 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/804
Author: abbra
Title: #804: krb5: make sure KDC certificate is readable
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/804/head:pr804
git checkout pr804

Loading...