Discussion:
[Freeipa-devel] [freeipa PR#792][comment] named.conf template: add modification warning
tomaskrizek
2017-05-22 16:49:44 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/792
Title: #792: named.conf template: add modification warning

tomaskrizek commented:
"""
- fixed the broken comment
- mentioned any changes should be documented in FreeIPA or Red Hat IdM documentation

I don't think going into more detail is necessary.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/792#issuecomment-303156828
tomaskrizek
2017-05-22 16:47:20 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/792
Author: tomaskrizek
Title: #792: named.conf template: add modification warning
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/792/head:pr792
git checkout pr792
stlaz
2017-05-23 06:45:56 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/792
Title: #792: named.conf template: add modification warning

stlaz commented:
"""
The IdM documentation does not list allowed operations on the file, only a note of what the file is most commonly used for.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/792#issuecomment-303305555
tomaskrizek
2017-05-23 07:42:23 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/792
Author: tomaskrizek
Title: #792: named.conf template: add modification warning
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/792/head:pr792
git checkout pr792
tomaskrizek
2017-05-23 07:43:07 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/792
Title: #792: named.conf template: add modification warning

tomaskrizek commented:
"""
Fair enough, let's go with a simple warning that changes may break IPA setup/upgrades.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/792#issuecomment-303316574
stlaz
2017-05-23 08:26:46 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/792
Title: #792: named.conf template: add modification warning

Label: +ack
MartinBasti
2017-05-23 10:38:16 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/792
Author: tomaskrizek
Title: #792: named.conf template: add modification warning
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/792/head:pr792
git checkout pr792
MartinBasti
2017-05-23 10:38:14 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/792
Title: #792: named.conf template: add modification warning

MartinBasti commented:
"""
master:

* a924efe847e725d6a4dde209f57521a9a899ef23 named.conf template: add modification warning


"""

See the full comment at https://github.com/freeipa/freeipa/pull/792#issuecomment-303359641
MartinBasti
2017-05-23 10:38:12 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/792
Title: #792: named.conf template: add modification warning

Label: +pushed

Loading...