Discussion:
[Freeipa-devel] [freeipa PR#666][opened] Fix anonymous principal handling in replica install
martbab
2017-03-28 15:51:32 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/666
Author: martbab
Title: #666: Fix anonymous principal handling in replica install
Action: opened

PR body:
"""
This PR should unblock replica install against <4.5 masters if `--no-pkinit`
option is given. Be aware of the non-working WebUI after install, this will be
fixed once local PKINIT will be implemented.

Requires https://github.com/freeipa/freeipa/pull/631
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/666/head:pr666
git checkout pr666
stlaz
2017-03-29 13:25:29 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/666
Title: #666: Fix anonymous principal handling in replica install

Label: +ack
stlaz
2017-03-29 13:24:30 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/666
Title: #666: Fix anonymous principal handling in replica install

stlaz commented:
"""
I actually did the review of https://github.com/freeipa/freeipa/pull/631 alongside this.
I do not think the order of adding the anonymous principal and setting up PKINIT matters that much. From what I saw in Kerberos guides, it's usually actually done after PKINIT setup since until then, the anonymous principal is pretty much unusable.
The problem was rather the testing of anonymous pkinit before the anonymous principal was added, that is just plainly weird and I'm glad that that's now fixed.
ACK since this fixes the issues mentioned in comments.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/666#issuecomment-290088490
MartinBasti
2017-03-30 11:23:03 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/666
Author: martbab
Title: #666: Fix anonymous principal handling in replica install
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/666/head:pr666
git checkout pr666
MartinBasti
2017-03-30 11:23:07 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/666
Title: #666: Fix anonymous principal handling in replica install

MartinBasti commented:
"""
needs rebase
"""

See the full comment at https://github.com/freeipa/freeipa/pull/666#issuecomment-290382082
MartinBasti
2017-03-30 11:23:10 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/666
Author: martbab
Title: #666: Fix anonymous principal handling in replica install
Action: reopened

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/666/head:pr666
git checkout pr666
martbab
2017-03-30 13:03:05 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/666
Author: martbab
Title: #666: Fix anonymous principal handling in replica install
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/666/head:pr666
git checkout pr666
MartinBasti
2017-03-30 13:32:21 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/666
Title: #666: Fix anonymous principal handling in replica install

Label: +pushed
MartinBasti
2017-03-30 13:32:24 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/666
Title: #666: Fix anonymous principal handling in replica install

MartinBasti commented:
"""
master:

* 191668e85be0b53020a56df409731812e528d101 Always check and create anonymous principal during KDC install
* 2eabb0dab7b4dab1c45395f3e02d43676d91f4a2 Remove duplicate functionality in upgrade


ipa-4-5:

* ce94f7fa7b4eca296d2f9692d35c2558bfeddb46 Always check and create anonymous principal during KDC install
* 0fcd56533a00c28f9f8f800c77b8c2c580cb3a8f Remove duplicate functionality in upgrade


"""

See the full comment at https://github.com/freeipa/freeipa/pull/666#issuecomment-290411432
MartinBasti
2017-03-30 13:32:25 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/666
Author: martbab
Title: #666: Fix anonymous principal handling in replica install
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/666/head:pr666
git checkout pr666

Loading...