[Freeipa-devel] [freeipa PR#677][opened] cert: defer cert-find result post-processing

[HonzaCholasta]

URL: https://github.com/freeipa/freeipa/pull/677
Author: HonzaCholasta
Title: #677: cert: defer cert-find result post-processing
Action: opened

PR body:
"""
Rather than post-processing the results of each internal search,
post-process the combined result.

This avoids expensive per-certificate searches on certificates which won't
even be included in the combined result when cert-find is executed with the
--all option.

https://pagure.io/freeipa/issue/6808
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/677/head:pr677
git checkout pr677

[HonzaCholasta]

URL: https://github.com/freeipa/freeipa/pull/677
Author: HonzaCholasta
Title: #677: cert: defer cert-find result post-processing
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/677/head:pr677
git checkout pr677

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/677
Title: #677: cert: defer cert-find result post-processing

stlaz commented:
"""
What worries me the most is that the tests are green even though this is potentially a serious problem.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/677#issuecomment-291471139

[HonzaCholasta]

URL: https://github.com/freeipa/freeipa/pull/677
Author: HonzaCholasta
Title: #677: cert: defer cert-find result post-processing
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/677/head:pr677
git checkout pr677

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/677
Title: #677: cert: defer cert-find result post-processing

stlaz commented:
"""
The patched IPA works better than the current 4.4 and 4.5 branches in terms of options logic, that's good.
From the code I am not sure which searches we do miss, could you elaborate on that a bit, please?
"""

See the full comment at https://github.com/freeipa/freeipa/pull/677#issuecomment-292142416

[HonzaCholasta]

URL: https://github.com/freeipa/freeipa/pull/677
Author: HonzaCholasta
Title: #677: cert: defer cert-find result post-processing
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/677/head:pr677
git checkout pr677

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/677
Title: #677: cert: defer cert-find result post-processing

Label: +ack

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/677
Title: #677: cert: defer cert-find result post-processing

stlaz commented:
"""
We may need these changes in 4.5 and 4.4, too since `cert-find` is rather broken there, too.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/677#issuecomment-295212663

[HonzaCholasta]

URL: https://github.com/freeipa/freeipa/pull/677
Title: #677: cert: defer cert-find result post-processing

HonzaCholasta commented:
"""
That might require backporting [issue 6564](https://pagure.io/freeipa/issue/6564) as well.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/677#issuecomment-295226720

[HonzaCholasta]

URL: https://github.com/freeipa/freeipa/pull/677
Title: #677: cert: defer cert-find result post-processing

HonzaCholasta commented:
"""
master:

* eb6d4c3037d0cc269a7924745f1cbd8f647e6e1a cert: defer cert-find result post-processing


ipa-4-5:

* 49f9d799c171c7ae2ac546a33a353c2c40b4719c cert: defer cert-find result post-processing


"""

See the full comment at https://github.com/freeipa/freeipa/pull/677#issuecomment-295228772

[HonzaCholasta]

URL: https://github.com/freeipa/freeipa/pull/677
Title: #677: cert: defer cert-find result post-processing

Label: +pushed

[HonzaCholasta]

URL: https://github.com/freeipa/freeipa/pull/677
Author: HonzaCholasta
Title: #677: cert: defer cert-find result post-processing
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/677/head:pr677
git checkout pr677