Discussion:
[Freeipa-devel] [freeipa PR#420][opened] WIP: Allow login to WebUI using Kerberos aliases/enterprise principals
martbab
2017-01-30 12:36:03 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/420
Author: martbab
Title: #420: WIP: Allow login to WebUI using Kerberos aliases/enterprise principals
Action: opened

PR body:
"""
The logic of the extraction/validation of principal from the request and
subsequent authentication was simplified and most of the guesswork will be done
by KDC during kinit. This allows for using principal aliases/enterprise
principals to log into WebUI and also lays foundation for enabling logons from
users from trusted domains.

https://fedorahosted.org/freeipa/ticket/6343
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/420/head:pr420
git checkout pr420
dkupka
2017-02-02 16:08:18 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/420
Title: #420: WIP: Allow login to WebUI using Kerberos aliases/enterprise principals

dkupka commented:
"""
LGTM and works as expected. Not ACKing only because it's marked as WIP.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/420#issuecomment-277000582
martbab
2017-02-03 08:35:40 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/420
Title: #420: WIP: Allow login to WebUI using Kerberos aliases/enterprise principals

martbab commented:
"""
I would wait with ACKing/pushing this PR until https://github.com/freeipa/freeipa/pull/314 is pushed.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/420#issuecomment-277192602
martbab
2017-02-28 12:53:00 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/420
Author: martbab
Title: #420: WIP: Allow login to WebUI using Kerberos aliases/enterprise principals
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/420/head:pr420
git checkout pr420
martbab
2017-02-28 12:53:40 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/420
Author: martbab
Title: #420: Allow login to WebUI using Kerberos aliases/enterprise principals
Action: edited

Changed field: title
Original value:
"""
WIP: Allow login to WebUI using Kerberos aliases/enterprise principals
"""
martbab
2017-02-28 12:54:20 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/420
Title: #420: Allow login to WebUI using Kerberos aliases/enterprise principals

martbab commented:
"""
Now that privilege separation was implemented I have rebased the PR and request a proper review of this patch.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/420#issuecomment-283031432
martbab
2017-03-06 08:14:31 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/420
Title: #420: Allow login to WebUI using Kerberos aliases/enterprise principals

martbab commented:
"""
@abbra can you also have a quick look at this PR if it is OK from the trusted user login perspective?
"""

See the full comment at https://github.com/freeipa/freeipa/pull/420#issuecomment-284329271
martbab
2017-03-07 13:45:34 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/420
Title: #420: Allow login to WebUI using Kerberos aliases/enterprise principals

martbab commented:
"""
@abbra I have a question regarding one of your comments, please review.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/420#issuecomment-284724932
martbab
2017-03-08 11:24:40 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/420
Author: martbab
Title: #420: Allow login to WebUI using Kerberos aliases/enterprise principals
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/420/head:pr420
git checkout pr420
abbra
2017-03-08 14:40:05 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/420
Title: #420: Allow login to WebUI using Kerberos aliases/enterprise principals

abbra commented:
"""
Thanks. LGTM and works for me with IPA user, IPA host principal, and AD user. The latter cannot yet actually use Web UI but that is a separate PR.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/420#issuecomment-285058056
abbra
2017-03-08 14:40:31 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/420
Title: #420: Allow login to WebUI using Kerberos aliases/enterprise principals

Label: +ack
dkupka
2017-03-08 14:56:40 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/420
Title: #420: Allow login to WebUI using Kerberos aliases/enterprise principals

Label: +pushed
dkupka
2017-03-08 14:56:39 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/420
Author: martbab
Title: #420: Allow login to WebUI using Kerberos aliases/enterprise principals
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/420/head:pr420
git checkout pr420
dkupka
2017-03-08 14:56:37 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/420
Title: #420: Allow login to WebUI using Kerberos aliases/enterprise principals

dkupka commented:
"""
master:

* f8d7e37a091c1df4c989b80b8d19e12ab35533c8 Allow login to WebUI using Kerberos aliases/enterprise principals
"""

See the full comment at https://github.com/freeipa/freeipa/pull/420#issuecomment-285062778
Loading...