Discussion:
[Freeipa-devel] [freeipa PR#634][opened] cert: do not limit internal searches in cert-find
HonzaCholasta
2017-03-22 07:24:58 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/634
Author: HonzaCholasta
Title: #634: cert: do not limit internal searches in cert-find
Action: opened

PR body:
"""
Instead, apply the limits on the combined result.

This fixes (absence of) `--sizelimit` leading to strange behavior, such as
`cert-find --users user` returning a non-empty result only with
`--sizelimit 0`.

https://pagure.io/freeipa/issue/6716
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/634/head:pr634
git checkout pr634
stlaz
2017-03-22 09:25:56 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/634
Title: #634: cert: do not limit internal searches in cert-find

stlaz commented:
"""
The tests obviously fail as they expect the `cert-find` command to respect the `sizelimit` option.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/634#issuecomment-288342471
HonzaCholasta
2017-03-22 09:34:33 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/634
Author: HonzaCholasta
Title: #634: cert: do not limit internal searches in cert-find
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/634/head:pr634
git checkout pr634
HonzaCholasta
2017-03-22 09:34:44 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/634
Title: #634: cert: do not limit internal searches in cert-find

HonzaCholasta commented:
"""
The fix was incomplete, it should be OK now.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/634#issuecomment-288344593
stlaz
2017-03-23 14:02:10 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/634
Title: #634: cert: do not limit internal searches in cert-find

stlaz commented:
"""
Works for me.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/634#issuecomment-288728368
stlaz
2017-03-23 14:02:15 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/634
Title: #634: cert: do not limit internal searches in cert-find

Label: +ack
martbab
2017-03-27 07:02:58 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/634
Title: #634: cert: do not limit internal searches in cert-find

Label: +pushed
martbab
2017-03-27 07:03:01 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/634
Title: #634: cert: do not limit internal searches in cert-find

martbab commented:
"""
master:

* 6de507c2cad255975665eca6dd6ef7c8f2458d51 cert: do not limit internal searches in cert-find
ipa-4-5:

* 6382f9eee335907362a5ccb44b892f59de7d3751 cert: do not limit internal searches in cert-find
"""

See the full comment at https://github.com/freeipa/freeipa/pull/634#issuecomment-289370236
martbab
2017-03-27 07:03:05 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/634
Author: HonzaCholasta
Title: #634: cert: do not limit internal searches in cert-find
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/634/head:pr634
git checkout pr634

Loading...