Discussion:
[Freeipa-devel] [freeipa PR#574][opened] ipa-replica-prepare fix
stlaz
2017-03-13 13:45:35 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/574
Author: stlaz
Title: #574: ipa-replica-prepare fix
Action: opened

PR body:
"""
A regression was introduced in https://github.com/freeipa/freeipa/commit/0a54fac02cecad3b9e3bf8ad0c8a44df3b701857. Fix + don't fail if either file was not created during server-cert creation.
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/574/head:pr574
git checkout pr574
stlaz
2017-03-13 13:46:48 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/574
Author: stlaz
Title: #574: ipa-replica-prepare fix
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/574/head:pr574
git checkout pr574
stlaz
2017-03-13 14:25:48 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/574
Author: stlaz
Title: #574: ipa-replica-prepare fix
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/574/head:pr574
git checkout pr574
MartinBasti
2017-03-13 17:00:34 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/574
Title: #574: ipa-replica-prepare fix

MartinBasti commented:
"""
Can be this caused by your patch?
```
error exporting Server certificate: Command '/usr/bin/openssl pkcs12 -export -name KDC-Cert -in /tmp/tmpmS5rCkipa/realm_info/kdc.pem -out /tmp/tmpmS5rCkipa/realm_info/pkinitcert.p12 -passout file:/tmp/tmpmS5rCkipa/realm_info/pkinit_pin.txt' returned non-zero exit status 1
```

"""

See the full comment at https://github.com/freeipa/freeipa/pull/574#issuecomment-286172238
stlaz
2017-03-13 18:43:46 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/574
Title: #574: ipa-replica-prepare fix

stlaz commented:
"""
Very unlikely but I'll investigate.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/574#issuecomment-286204519
stlaz
2017-03-13 19:13:29 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/574
Title: #574: ipa-replica-prepare fix

stlaz commented:
"""
My wild guess is that it might be caused by ba3c201a but not by this patchset as it does not touch it.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/574#issuecomment-286212984
stlaz
2017-03-14 07:33:28 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/574
Title: #574: ipa-replica-prepare fix

stlaz commented:
"""
Actually, this is most probably a privilege-separation issue since "kdc.pem" which we try to read here does not exist ever since.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/574#issuecomment-286343464
stlaz
2017-03-14 07:41:32 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/574
Title: #574: ipa-replica-prepare fix

stlaz commented:
"""
Actually, this is most probably a privilege-separation issue since "kdc.pem" which we try to read here does not exist ever since.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/574#issuecomment-286343464
stlaz
2017-03-14 08:24:55 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/574
Title: #574: ipa-replica-prepare fix

stlaz commented:
"""
@MartinBasti should be fixed in https://github.com/freeipa/freeipa/pull/580
"""

See the full comment at https://github.com/freeipa/freeipa/pull/574#issuecomment-286352636
MartinBasti
2017-03-14 08:54:26 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/574
Title: #574: ipa-replica-prepare fix

Label: +ack
MartinBasti
2017-03-14 14:03:10 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/574
Title: #574: ipa-replica-prepare fix

Label: +pushed
MartinBasti
2017-03-14 14:03:12 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/574
Title: #574: ipa-replica-prepare fix

MartinBasti commented:
"""
master:

* 992e6ecd1ff33f4f872e8f174bd426507c55f5c4 Fix ipa-replica-prepare server-cert creation
* 8980f4098ebf6b62556e24f090718802d1e495d3 Don't fail more if cert req/cert creation failed
"""

See the full comment at https://github.com/freeipa/freeipa/pull/574#issuecomment-286430379
MartinBasti
2017-03-14 14:03:09 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/574
Author: stlaz
Title: #574: ipa-replica-prepare fix
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/574/head:pr574
git checkout pr574

Loading...