Discussion:
[Freeipa-devel] [freeipa PR#561][opened] ldap2: fix crash in development mode
HonzaCholasta
2017-03-09 13:43:56 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/561
Author: HonzaCholasta
Title: #561: ldap2: fix crash in development mode
Action: opened

PR body:
"""
Do not set or delete attributes directly on the ldap2 instance, as that
raises an AttributeError in development mode because of ReadOnly locking.

Use the usual workaround of object.__setattr__ and .__delattr__ to fix the
issue.

https://pagure.io/freeipa/issue/6625
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/561/head:pr561
git checkout pr561
HonzaCholasta
2017-03-09 13:44:41 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/561
Author: HonzaCholasta
Title: #561: ldap2: fix crash in development mode
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/561/head:pr561
git checkout pr561
HonzaCholasta
2017-03-09 13:44:54 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/561
Author: HonzaCholasta
Title: #561: ldap2: fix crash in development mode
Action: edited

Changed field: body
Original value:
"""
Do not set or delete attributes directly on the ldap2 instance, as that
raises an AttributeError in development mode because of ReadOnly locking.

Use the usual workaround of object.__setattr__ and .__delattr__ to fix the
issue.

https://pagure.io/freeipa/issue/6625
"""
tomaskrizek
2017-03-09 15:30:16 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/561
Title: #561: ldap2: fix crash in development mode

tomaskrizek commented:
"""
Seems to work all right, but the locking issue still affects other parts of the code. For example, `ipa cert-show` in development mode fails with:

```
AttributeError: locked: cannot set ra_lightweight_ca.cookie
```

I'm not sure if that's in the ticket's scope or not.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/561#issuecomment-285383760
HonzaCholasta
2017-03-10 05:30:23 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/561
Author: HonzaCholasta
Title: #561: ldap2: fix crash in development mode
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/561/head:pr561
git checkout pr561
HonzaCholasta
2017-03-10 05:31:20 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/561
Title: #561: ldap2: fix crash in development mode

HonzaCholasta commented:
"""
Let's see what Travis detects.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/561#issuecomment-285582277
HonzaCholasta
2017-03-10 06:16:49 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/561
Author: HonzaCholasta
Title: #561: ldap2: fix crash in development mode
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/561/head:pr561
git checkout pr561
HonzaCholasta
2017-03-10 07:03:25 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/561
Title: #561: ldap2: fix crash in development mode

HonzaCholasta commented:
"""
Travis didn't detect anything else, so I think we are good to go. Shall we keep the `.test_runner_config.yaml` change? (@martbab?)
"""

See the full comment at https://github.com/freeipa/freeipa/pull/561#issuecomment-285594083
martbab
2017-03-10 08:23:45 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/561
Title: #561: ldap2: fix crash in development mode

martbab commented:
"""
Yes but please split it into a separate patch so that CI-related changes are tracked separately and do not pollute the changes in the code.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/561#issuecomment-285607215
HonzaCholasta
2017-03-10 09:44:23 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/561
Author: HonzaCholasta
Title: #561: ldap2: fix crash in development mode
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/561/head:pr561
git checkout pr561
HonzaCholasta
2017-03-10 09:46:27 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/561
Title: #561: ldap2: fix crash in development mode

HonzaCholasta commented:
"""
Turns out unsetting mode in default.conf is not good enough, one has to explicitly set it to "development" to enable development mode, because "production" is the default.

Let's see if Travis detects something this time.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/561#issuecomment-285624395
HonzaCholasta
2017-03-10 12:01:27 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/561
Author: HonzaCholasta
Title: #561: ldap2: fix crash in development mode
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/561/head:pr561
git checkout pr561
HonzaCholasta
2017-03-10 14:08:48 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/561
Author: HonzaCholasta
Title: #561: ldap2: fix crash in development mode
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/561/head:pr561
git checkout pr561
HonzaCholasta
2017-03-13 06:08:13 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/561
Title: #561: ldap2: fix crash in development mode

HonzaCholasta commented:
"""
OK everything is green now.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/561#issuecomment-286022821
tomaskrizek
2017-03-13 11:11:06 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/561
Title: #561: ldap2: fix crash in development mode

Label: +ack
MartinBasti
2017-03-13 15:07:06 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/561
Title: #561: ldap2: fix crash in development mode

Label: +pushed
MartinBasti
2017-03-13 15:07:07 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/561
Title: #561: ldap2: fix crash in development mode

MartinBasti commented:
"""
master:

* 8fdd7a9ffc263c1198afa5479cda41d319f11d91 backend plugins: fix crashes in development mode
* fe4489ede2b40902fb7d734d04a1f997c6df86fb Travis CI: run tests in development mode
"""

See the full comment at https://github.com/freeipa/freeipa/pull/561#issuecomment-286135528
MartinBasti
2017-03-13 15:07:09 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/561
Author: HonzaCholasta
Title: #561: ldap2: fix crash in development mode
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/561/head:pr561
git checkout pr561

Loading...