Discussion:
[Freeipa-devel] [freeipa PR#651][opened] WebUI: Fix showing vault in selfservice view
pvomacka
2017-03-24 09:43:30 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/651
Author: pvomacka
Title: #651: WebUI: Fix showing vault in selfservice view
Action: opened

PR body:
"""
Vaults menu item was shown even when the KRA service was not installed.
That was caused by different path to the menu item in admin's view
and in selfservice view.

The path is now set correctly for both situations. 'network_service/vault'
for admin's view and 'vault' for selfservice view.

https://pagure.io/freeipa/issue/6812
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/651/head:pr651
git checkout pr651
pvoborni
2017-03-24 10:50:48 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/651
Title: #651: WebUI: Fix showing vault in selfservice view

pvoborni commented:
"""
Works fine. ACK
"""

See the full comment at https://github.com/freeipa/freeipa/pull/651#issuecomment-288990983
pvoborni
2017-03-24 10:50:57 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/651
Title: #651: WebUI: Fix showing vault in selfservice view

Label: +ack
pvomacka
2017-03-27 16:20:32 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/651
Title: #651: WebUI: Fix showing vault in selfservice view

Label: +pushed
pvomacka
2017-03-27 16:20:42 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/651
Author: pvomacka
Title: #651: WebUI: Fix showing vault in selfservice view
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/651/head:pr651
git checkout pr651
pvomacka
2017-03-27 16:20:39 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/651
Title: #651: WebUI: Fix showing vault in selfservice view

pvomacka commented:
"""
ipa-4-5:

* 7b3cb1ccad28a1fd17803bdd7dd245bdfee9a046 WebUI: Fix showing vault in selfservice view
master:

* ab6d7ac50a93efa6a9e3566dbe07b34a23c41cce WebUI: Fix showing vault in selfservice view
"""

See the full comment at https://github.com/freeipa/freeipa/pull/651#issuecomment-289505248
Loading...