[Freeipa-devel] [freeipa PR#556][opened] Don't allow standalone KRA uninstalls

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/556
Author: stlaz
Title: #556: Don't allow standalone KRA uninstalls
Action: opened

PR body:
"""
KRA uninstallation is very likely to break the user's setup. Don't
allow it at least till we can be safely sure we are able to remove
it in a standalone manner without breaking anything.

https://pagure.io/freeipa/issue/6538
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/556/head:pr556
git checkout pr556

[tomaskrizek]

URL: https://github.com/freeipa/freeipa/pull/556
Title: #556: Don't allow standalone KRA uninstalls

tomaskrizek commented:
"""
You should also remove:

```
ipaplatform/base/paths.py:313: IPASERVER_KRA_UNINSTALL_LOG
ipatests/test_integration/tasks.py:71: host.collect_log(paths.IPASERVER_KRA_UNINSTALL_LOG)
ipatests/test_integration/tasks.py:73: host.collect_log(paths.IPASERVER_KRA_UNINSTALL_LOG)
ipatests/test_integration/test_vault.py:145: def test_create_and_retrieve_vault_after_kra_uninstall_on_replica
```
"""

See the full comment at https://github.com/freeipa/freeipa/pull/556#issuecomment-285299507

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/556
Author: stlaz
Title: #556: Don't allow standalone KRA uninstalls
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/556/head:pr556
git checkout pr556

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/556
Title: #556: Don't allow standalone KRA uninstalls

stlaz commented:
"""
Should be fixed now, had to add `sys.exit()` call not to show traceback 😞
"""

See the full comment at https://github.com/freeipa/freeipa/pull/556#issuecomment-285322583

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/556
Author: stlaz
Title: #556: Don't allow standalone KRA uninstalls
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/556/head:pr556
git checkout pr556

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/556
Title: #556: Don't allow standalone KRA uninstalls

MartinBasti commented:
"""
`ScriptError` didn't work?
"""

See the full comment at https://github.com/freeipa/freeipa/pull/556#issuecomment-285341002

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/556
Title: #556: Don't allow standalone KRA uninstalls

stlaz commented:
"""
@MartinBasti unfortunately not.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/556#issuecomment-285344820

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/556
Author: stlaz
Title: #556: Don't allow standalone KRA uninstalls
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/556/head:pr556
git checkout pr556

[tomaskrizek]

URL: https://github.com/freeipa/freeipa/pull/556
Title: #556: Don't allow standalone KRA uninstalls

Label: +ack

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/556
Title: #556: Don't allow standalone KRA uninstalls

MartinBasti commented:
"""
Waiting for more opinions about removing KRA --uninstall
"""

See the full comment at https://github.com/freeipa/freeipa/pull/556#issuecomment-285352065

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/556
Title: #556: Don't allow standalone KRA uninstalls

Label: -ack

[pvoborni]

URL: https://github.com/freeipa/freeipa/pull/556
Title: #556: Don't allow standalone KRA uninstalls

pvoborni commented:
"""
OK, so this pr remove `--uninstall` from `ipa-kra-install`. Did it work in the past? Or it always broke the installation? AFAIK this workflow was not really tested. If answers are "No, Yes, Yes" then I'm OK with the PR.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/556#issuecomment-285354949

[pvoborni]

URL: https://github.com/freeipa/freeipa/pull/556
Title: #556: Don't allow standalone KRA uninstalls

pvoborni commented:
"""
OK, so this pr remove `--uninstall` from `ipa-kra-install`. Did it work in the past? Or it always broke the installation? AFAIK this workflow was not really tested. If answers are "No, Yes, Yes" then I'm OK with the PR.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/556#issuecomment-285354949

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/556
Title: #556: Don't allow standalone KRA uninstalls

Label: +ack

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/556
Title: #556: Don't allow standalone KRA uninstalls

MartinBasti commented:
"""
needs rebase

"""

See the full comment at https://github.com/freeipa/freeipa/pull/556#issuecomment-286137069

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/556
Author: stlaz
Title: #556: Don't allow standalone KRA uninstalls
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/556/head:pr556
git checkout pr556

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/556
Title: #556: Don't allow standalone KRA uninstalls

stlaz commented:
"""
Rebased.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/556#issuecomment-286139764

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/556
Title: #556: Don't allow standalone KRA uninstalls

MartinBasti commented:
"""
master:

* 5d3a0e6758866239c886e998a6d89c5a4b150184 Don't allow standalone KRA uninstalls
"""

See the full comment at https://github.com/freeipa/freeipa/pull/556#issuecomment-286142058

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/556
Author: stlaz
Title: #556: Don't allow standalone KRA uninstalls
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/556/head:pr556
git checkout pr556

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/556
Title: #556: Don't allow standalone KRA uninstalls

Label: +pushed