Discussion:
[Freeipa-devel] [freeipa PR#714][opened] fix minor typo in ipa-adtrust-install.1
realsobek
2017-04-15 11:57:20 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/714
Author: realsobek
Title: #714: fix minor typo in ipa-adtrust-install.1
Action: opened

PR body:
"""

"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/714/head:pr714
git checkout pr714
realsobek
2017-04-15 12:19:17 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/714
Author: realsobek
Title: #714: fix minor typo in ipa-adtrust-install.1
Action: edited

Changed field: body
Original value:
"""

"""
realsobek
2017-04-23 18:12:18 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/714
Author: realsobek
Title: #714: fix minor typo in ipa-adtrust-install.1
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/714/head:pr714
git checkout pr714
realsobek
2017-04-23 18:47:26 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/714
Title: #714: fix minor typo in ipa-adtrust-install.1

realsobek commented:
"""
fix has been added
"""

See the full comment at https://github.com/freeipa/freeipa/pull/714#issuecomment-296477544
stlaz
2017-04-24 05:57:11 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/714
Title: #714: fix minor typo in ipa-adtrust-install.1

stlaz commented:
"""
Thanks, ACK.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/714#issuecomment-296531049
stlaz
2017-04-24 05:57:18 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/714
Title: #714: fix minor typo in ipa-adtrust-install.1

Label: +ack
stlaz
2017-04-24 08:23:51 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/714
Title: #714: fix minor typo in ipa-adtrust-install.1

Label: -ack
stlaz
2017-04-24 08:24:46 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/714
Title: #714: fix minor typo in ipa-adtrust-install.1

stlaz commented:
"""
Ah, I did not notice you made a second commit for this. Please, squash them.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/714#issuecomment-296573574
realsobek
2017-04-24 20:37:35 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/714
Author: realsobek
Title: #714: fix minor typo in ipa-adtrust-install.1
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/714/head:pr714
git checkout pr714
realsobek
2017-04-24 21:09:38 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/714
Title: #714: fix minor typo in ipa-adtrust-install.1

realsobek commented:
"""
It was my fault. I knew how to squash two unpushed commits, but squashing two pushed commits was beyond me.
Thanks for your comment in #716 I had a look again and I managed it this time. :)
I squashed the last two commits (see `git log`) in my branch with `git rebase --interactive HEAD~2` and pushed the result to my fork with `git push origin master --force`
"""

See the full comment at https://github.com/freeipa/freeipa/pull/714#issuecomment-296823122
stlaz
2017-04-25 05:58:29 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/714
Title: #714: fix minor typo in ipa-adtrust-install.1

stlaz commented:
"""
Thanks, now this is ready to be pushed :)
"""

See the full comment at https://github.com/freeipa/freeipa/pull/714#issuecomment-296920348
stlaz
2017-04-25 05:58:34 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/714
Title: #714: fix minor typo in ipa-adtrust-install.1

Label: +ack
MartinBasti
2017-04-25 10:21:10 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/714
Title: #714: fix minor typo in ipa-adtrust-install.1

Label: +pushed
MartinBasti
2017-04-25 10:21:13 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/714
Title: #714: fix minor typo in ipa-adtrust-install.1

MartinBasti commented:
"""
master:

* 298f725e5b2f820369c337dd1ab4bfd9ad3cd01f fix minor typos in ipa-adtrust-install.1


"""

See the full comment at https://github.com/freeipa/freeipa/pull/714#issuecomment-296987097
MartinBasti
2017-04-25 10:21:16 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/714
Author: realsobek
Title: #714: fix minor typo in ipa-adtrust-install.1
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/714/head:pr714
git checkout pr714

Loading...