Discussion:
[Freeipa-devel] [freeipa PR#433][opened] csrgen: Allow some certificate fields to be specified by the user
LiptonB
2017-02-04 13:57:54 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/433
Author: LiptonB
Title: #433: csrgen: Allow some certificate fields to be specified by the user
Action: opened

PR body:
"""
These patches allow CSR generation rules to contain a "prompt," which will cause data to be requested from the user and interpolated into the CSR.

The second commit runs the prompt through gettext. As I asked about [here](https://www.redhat.com/archives/freeipa-devel/2016-August/msg00823.html), I'm not sure if this is useful because the prompt strings in the rule files won't be recognized as translatable. But I decided to include the commit for discussion.
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/433/head:pr433
git checkout pr433
MartinBasti
2017-02-07 17:54:24 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/433
Title: #433: csrgen: Allow some certificate fields to be specified by the user

MartinBasti commented:
"""
```
************* Module ipaclient.csrgen
ipaclient/csrgen.py:376: [E1101(no-member), CSRGenerator.get_user_prompts] Module 'ipalib.errors' has no 'CertificateMappingError' member)
ipaclient/csrgen.py:380: [E1101(no-member), CSRGenerator.get_user_prompts] Module 'ipalib.errors' has no 'CertificateMappingError' member)
ipaclient/csrgen.py:385: [E1101(no-member), CSRGenerator.get_user_prompts] Module 'ipalib.errors' has no 'CertificateMappingError' member)
ipaclient/csrgen.py:367: [W0612(unused-variable), CSRGenerator.get_user_prompts] Unused variable 'syntax_rules')
************* Module ipatests.test_ipaclient.test_csrgen
ipatests/test_ipaclient/test_csrgen.py:322: [W0612(unused-variable), test_rule_handling.test_userdata_included] Unused variable 'script')
ipatests/test_ipaclient/test_csrgen.py:324: [W0612(unused-variable), test_rule_handling.test_userdata_included] Unused variable 'expected_script'm)
```
"""

See the full comment at https://github.com/freeipa/freeipa/pull/433#issuecomment-278083528
LiptonB
2017-02-09 03:15:52 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/433
Author: LiptonB
Title: #433: csrgen: Allow some certificate fields to be specified by the user
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/433/head:pr433
git checkout pr433
LiptonB
2017-02-09 13:17:30 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/433
Title: #433: csrgen: Allow some certificate fields to be specified by the user

LiptonB commented:
"""
Sorry for submitting this with lint errors - fixed now.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/433#issuecomment-278637593
LiptonB
2017-03-06 15:53:57 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/433
Author: LiptonB
Title: #433: csrgen: Allow some certificate fields to be specified by the user
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/433/head:pr433
git checkout pr433
tiran
2017-03-14 17:00:58 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/433
Title: #433: csrgen: Allow some certificate fields to be specified by the user

tiran commented:
"""
@LiptonB please resolve conflicts
"""

See the full comment at https://github.com/freeipa/freeipa/pull/433#issuecomment-286489002
LiptonB
2017-03-15 15:59:45 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/433
Author: LiptonB
Title: #433: csrgen: Allow some certificate fields to be specified by the user
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/433/head:pr433
git checkout pr433
LiptonB
2017-03-15 17:22:08 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/433
Title: #433: csrgen: Allow some certificate fields to be specified by the user

LiptonB commented:
"""
Rebased, thanks.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/433#issuecomment-286816039
LiptonB
2017-04-16 23:49:02 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/433
Author: LiptonB
Title: #433: csrgen: Allow some certificate fields to be specified by the user
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/433/head:pr433
git checkout pr433

Loading...