Discussion:
[Freeipa-devel] [freeipa PR#575][opened] IPA certauth plugin
sumit-bose
2017-03-13 14:50:04 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/575
Author: sumit-bose
Title: #575: IPA certauth plugin
Action: opened

PR body:
"""
This patch add a certauth plugin which allows the IPA server to support
PKINIT for certificates which do not include a special SAN extension which
contains a Kerberos principal but allow other mappings with the help of
SSSD's certmap library.

Related to https://pagure.io/freeipa/issue/4905
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/575/head:pr575
git checkout pr575
sumit-bose
2017-03-13 15:12:31 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/575
Title: #575: IPA certauth plugin

sumit-bose commented:
"""
This patch depends on https://github.com/SSSD/sssd/pull/192 (SSSD's certmap library) and https://github.com/krb5/krb5/pull/610 (MIT Kerberos certauth plugin support)
"""

See the full comment at https://github.com/freeipa/freeipa/pull/575#issuecomment-286137210
sumit-bose
2017-03-14 09:55:02 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/575
Author: sumit-bose
Title: #575: IPA certauth plugin
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/575/head:pr575
git checkout pr575
sumit-bose
2017-03-14 09:56:17 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/575
Title: #575: IPA certauth plugin

sumit-bose commented:
"""
I updated the code to reflect the latest changes in the interface from https://github.com/krb5/krb5/pull/610.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/575#issuecomment-286373480
abbra
2017-03-23 11:10:18 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/575
Title: #575: IPA certauth plugin

abbra commented:
"""
The code LGTM. Once updated SSSD is added to freeipa-master copr, let's see what CI says.

Authentication indicators' handling would need to be added in a separate PR once certmap rules would provide the indicator value.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/575#issuecomment-288686687
sumit-bose
2017-03-23 14:49:55 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/575
Author: sumit-bose
Title: #575: IPA certauth plugin
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/575/head:pr575
git checkout pr575
sumit-bose
2017-03-24 07:48:04 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/575
Author: sumit-bose
Title: #575: IPA certauth plugin
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/575/head:pr575
git checkout pr575
sumit-bose
2017-03-27 06:39:38 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/575
Author: sumit-bose
Title: #575: IPA certauth plugin
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/575/head:pr575
git checkout pr575
sumit-bose
2017-03-27 06:48:59 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/575
Author: sumit-bose
Title: #575: IPA certauth plugin
Action: reopened

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/575/head:pr575
git checkout pr575
sumit-bose
2017-03-27 06:48:55 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/575
Author: sumit-bose
Title: #575: IPA certauth plugin
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/575/head:pr575
git checkout pr575
dkupka
2017-03-27 07:04:17 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/575
Title: #575: IPA certauth plugin

dkupka commented:
"""
I've tested the patches and it worked as expected. Once CI successfully finishes I'll ACK it.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/575#issuecomment-289370441
dkupka
2017-03-27 07:53:37 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/575
Title: #575: IPA certauth plugin

dkupka commented:
"""
master:

* da880decfedc66f9d0d2734dcb86c23a8866f603 ipa-kdb: add ipadb_fetch_principals_with_extra_filter()
* c4156041feb9c48598427ad59e43313b9c7327bb IPA certauth plugin
ipa-4-5:

* cfaaf4e821338dbc146dd49d3c22978165d2e329 ipa-kdb: add ipadb_fetch_principals_with_extra_filter()
* 5a1ce1fbaa6c7a85bd1bee2a70b8b22509ede7c7 IPA certauth plugin
"""

See the full comment at https://github.com/freeipa/freeipa/pull/575#issuecomment-289379658
dkupka
2017-03-27 07:53:40 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/575
Author: sumit-bose
Title: #575: IPA certauth plugin
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/575/head:pr575
git checkout pr575
dkupka
2017-03-27 07:49:54 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/575
Title: #575: IPA certauth plugin

Label: +ack
dkupka
2017-03-27 07:53:42 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/575
Title: #575: IPA certauth plugin

Label: +pushed

Loading...