[Freeipa-devel] [freeipa PR#540][opened] rabase.get_certificate: make serial number arg mandatory

[frasertweedale]

URL: https://github.com/freeipa/freeipa/pull/540
Author: frasertweedale
Title: #540: rabase.get_certificate: make serial number arg mandatory
Action: opened

PR body:
"""
In rabase.get_certificate it does not make sense for the
serial_number argument to be optional. Make it a mandatory
positional argument.

Part of: https://pagure.io/freeipa/issue/3473
Part of: https://pagure.io/freeipa/issue/5011
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/540/head:pr540
git checkout pr540

[tomaskrizek]

URL: https://github.com/freeipa/freeipa/pull/540
Title: #540: rabase.get_certificate: make serial number arg mandatory

Label: +ack

[tomaskrizek]

URL: https://github.com/freeipa/freeipa/pull/540
Title: #540: rabase.get_certificate: make serial number arg mandatory

Label: +pushed

[tomaskrizek]

URL: https://github.com/freeipa/freeipa/pull/540
Author: frasertweedale
Title: #540: rabase.get_certificate: make serial number arg mandatory
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/540/head:pr540
git checkout pr540

[tomaskrizek]

URL: https://github.com/freeipa/freeipa/pull/540
Title: #540: rabase.get_certificate: make serial number arg mandatory

tomaskrizek commented:
"""
master:

* 3ba0375c831eca673c2df146b565a32dbc03fdb3 rabase.get_certificate: make serial number arg mandatory
"""

See the full comment at https://github.com/freeipa/freeipa/pull/540#issuecomment-284707795