Discussion:
[Freeipa-devel] [freeipa PR#668][opened] spec file: bump libsss_nss_idmap-devel BuildRequires
HonzaCholasta
2017-03-29 07:24:39 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/668
Author: HonzaCholasta
Title: #668: spec file: bump libsss_nss_idmap-devel BuildRequires
Action: opened

PR body:
"""
Bump BuildRequires on libsss_nss_idmap-devel to the version which
introduces the sss_nss_getlistbycert function.

This fixes RPM build failure when an older version of
libsss_nss_idmap-devel was installed.

https://pagure.io/freeipa/issue/6826
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/668/head:pr668
git checkout pr668
tomaskrizek
2017-03-29 07:32:09 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/668
Title: #668: spec file: bump libsss_nss_idmap-devel BuildRequires

tomaskrizek commented:
"""
Do we also need to bump the version in `PKG_CHECK_MODULES` in `server.m4:31`?

```
PKG_CHECK_MODULES([SSSNSSIDMAP], [sss_nss_idmap >= 1.15.2])
```
"""

See the full comment at https://github.com/freeipa/freeipa/pull/668#issuecomment-290007481
abbra
2017-03-29 07:42:13 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/668
Title: #668: spec file: bump libsss_nss_idmap-devel BuildRequires

abbra commented:
"""
No, It will make downstream harder because RHEL downstream will only have 1.15.2 with patches on top of that version.

I have a pull request coming that actually checks for a specific function we know is part of those SSSD patches.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/668#issuecomment-290009593
abbra
2017-03-29 07:45:04 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/668
Title: #668: spec file: bump libsss_nss_idmap-devel BuildRequires

abbra commented:
"""
I submitted https://github.com/freeipa/freeipa/pull/669 for that
"""

See the full comment at https://github.com/freeipa/freeipa/pull/668#issuecomment-290010251
tomaskrizek
2017-03-29 07:52:56 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/668
Title: #668: spec file: bump libsss_nss_idmap-devel BuildRequires

tomaskrizek commented:
"""
We still want to merge this PR to take care of the upstream BuildRequires though, right?
"""

See the full comment at https://github.com/freeipa/freeipa/pull/668#issuecomment-290012044
HonzaCholasta
2017-03-29 08:07:31 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/668
Title: #668: spec file: bump libsss_nss_idmap-devel BuildRequires

HonzaCholasta commented:
"""
Right.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/668#issuecomment-290015269
tomaskrizek
2017-03-29 08:26:01 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/668
Title: #668: spec file: bump libsss_nss_idmap-devel BuildRequires

Label: +ack
HonzaCholasta
2017-03-29 08:30:30 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/668
Title: #668: spec file: bump libsss_nss_idmap-devel BuildRequires

HonzaCholasta commented:
"""
Changed ticket link to https://pagure.io/freeipa/issue/6828.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/668#issuecomment-290020664
HonzaCholasta
2017-03-29 08:30:18 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/668
Author: HonzaCholasta
Title: #668: spec file: bump libsss_nss_idmap-devel BuildRequires
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/668/head:pr668
git checkout pr668
tomaskrizek
2017-03-29 08:34:20 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/668
Title: #668: spec file: bump libsss_nss_idmap-devel BuildRequires

Label: +pushed
tomaskrizek
2017-03-29 08:34:28 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/668
Title: #668: spec file: bump libsss_nss_idmap-devel BuildRequires

tomaskrizek commented:
"""
master:

* b18ee8b9dd3b1d0cfdc45373a7a56747e1f993a3 spec file: bump libsss_nss_idmap-devel BuildRequires
ipa-4-5:

* 127f7ce699677d8c689099eac350a54293a5009d spec file: bump libsss_nss_idmap-devel BuildRequires
"""

See the full comment at https://github.com/freeipa/freeipa/pull/668#issuecomment-290021579
tomaskrizek
2017-03-29 08:34:34 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/668
Author: HonzaCholasta
Title: #668: spec file: bump libsss_nss_idmap-devel BuildRequires
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/668/head:pr668
git checkout pr668

Loading...