Discussion:
[Freeipa-devel] [freeipa PR#660][opened] rpcserver.login_x509: Actually return reply from __call__ method
dkupka
2017-03-27 14:14:38 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/660
Author: dkupka
Title: #660: rpcserver.login_x509: Actually return reply from __call__ method
Action: opened

PR body:
"""
__call__ didn't return causing internal error in wsgi application. Previously
this bug was hidden by some other error and the code worked even though it
shouldn't.

https://pagure.io/freeipa/issue/6225
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/660/head:pr660
git checkout pr660
pvomacka
2017-03-27 16:43:44 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/660
Title: #660: rpcserver.login_x509: Actually return reply from __call__ method

pvomacka commented:
"""
Please change ticket to this one: https://pagure.io/freeipa/issue/6819
"""

See the full comment at https://github.com/freeipa/freeipa/pull/660#issuecomment-289511868
dkupka
2017-03-28 06:38:36 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/660
Author: dkupka
Title: #660: rpcserver.login_x509: Actually return reply from __call__ method
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/660/head:pr660
git checkout pr660
pvomacka
2017-03-28 07:19:11 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/660
Title: #660: rpcserver.login_x509: Actually return reply from __call__ method

Label: +ack
pvomacka
2017-03-28 11:05:27 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/660
Author: dkupka
Title: #660: rpcserver.login_x509: Actually return reply from __call__ method
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/660/head:pr660
git checkout pr660
pvomacka
2017-03-28 11:05:24 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/660
Title: #660: rpcserver.login_x509: Actually return reply from __call__ method

Label: +pushed
pvomacka
2017-03-28 11:05:30 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/660
Title: #660: rpcserver.login_x509: Actually return reply from __call__ method

pvomacka commented:
"""
ipa-4-5:

* c80941e98bfd00c1c6e530aa4a592354adff8d90 rpcserver.login_x509: Actually return reply from __call__ method
master:

* 7e1fdd2c5881893fd9540689045a11f9e88beef9 rpcserver.login_x509: Actually return reply from __call__ method
"""

See the full comment at https://github.com/freeipa/freeipa/pull/660#issuecomment-289736121
Loading...