Discussion:
[Freeipa-devel] [freeipa PR#331][opened] WebUI: don't change casing of Auth Indicators values
pvomacka
2016-12-13 12:31:10 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/331
Author: pvomacka
Title: #331: WebUI: don't change casing of Auth Indicators values
Action: opened

PR body:
"""
All values were previously converted to lowercase which was not
coresponding with CLI behaviour. Now they stay as they are
inserted. I also have to change the strings to lowercase because
the otp and radius should be inserted as lowercase words.

https://fedorahosted.org/freeipa/ticket/6308

"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/331/head:pr331
git checkout pr331
pvomacka
2017-02-15 11:04:50 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/331
Author: pvomacka
Title: #331: WebUI: don't change casing of Auth Indicators values
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/331/head:pr331
git checkout pr331
pvoborni
2017-02-15 11:17:50 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/331
Title: #331: WebUI: don't change casing of Auth Indicators values

pvoborni commented:
"""
LGTM (reading code).
"""

See the full comment at https://github.com/freeipa/freeipa/pull/331#issuecomment-279984562
pvomacka
2017-03-08 11:24:35 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/331
Author: pvomacka
Title: #331: WebUI: don't change casing of Auth Indicators values
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/331/head:pr331
git checkout pr331
pvoborni
2017-03-08 13:42:27 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/331
Title: #331: WebUI: don't change casing of Auth Indicators values

Label: +ack
pvoborni
2017-03-08 13:42:18 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/331
Title: #331: WebUI: don't change casing of Auth Indicators values

pvoborni commented:
"""
ACK but I've find out that the change is not enough because of existing bug. See pr #554
"""

See the full comment at https://github.com/freeipa/freeipa/pull/331#issuecomment-285043268
dkupka
2017-03-08 14:43:38 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/331
Title: #331: WebUI: don't change casing of Auth Indicators values

dkupka commented:
"""
master:

* 0220fc8986e4fef017185bde675dc9cf0f90afd8 WebUI: Allow disabling lowering text in custom_checkbox_widget
* ad3451067ad474ea52872913d6789b1652f9a9c4 WebUI: don't change casing of Auth Indicators values
"""

See the full comment at https://github.com/freeipa/freeipa/pull/331#issuecomment-285058994
dkupka
2017-03-08 14:43:36 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/331
Title: #331: WebUI: don't change casing of Auth Indicators values

Label: +pushed
dkupka
2017-03-08 14:43:40 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/331
Author: pvomacka
Title: #331: WebUI: don't change casing of Auth Indicators values
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/331/head:pr331
git checkout pr331

Loading...