Discussion:
[Freeipa-devel] [freeipa PR#619][opened] pytest 3.x compatibility
tiran
2017-03-17 17:22:48 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/619
Author: tiran
Title: #619: pytest 3.x compatibility
Action: opened

PR body:
"""
pytest 3.x does no longer support plain pytest.skip() on module level.

Signed-off-by: Christian Heimes <***@redhat.com>
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/619/head:pr619
git checkout pr619
MartinBasti
2017-03-17 20:05:22 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/619
Title: #619: pytest 3.x compatibility

MartinBasti commented:
"""
```
************* Module ipatests.util
ipatests/util.py:73: [E1123(unexpected-keyword-arg), check_ipaclient_unittests] Unexpected keyword argument 'allow_module_level' in constructor call)
```
"""

See the full comment at https://github.com/freeipa/freeipa/pull/619#issuecomment-287457701
tiran
2017-03-17 20:50:45 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/619
Author: tiran
Title: #619: pytest 3.x compatibility
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/619/head:pr619
git checkout pr619
tiran
2017-03-22 10:17:17 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/619
Title: #619: pytest 3.x compatibility

tiran commented:
"""
@martbab @MartinBasti Do you agree with the workaround or do you want to suggest a different approach?
"""

See the full comment at https://github.com/freeipa/freeipa/pull/619#issuecomment-288354736
MartinBasti
2017-03-22 16:07:38 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/619
Title: #619: pytest 3.x compatibility

MartinBasti commented:
"""
LGTM
"""

See the full comment at https://github.com/freeipa/freeipa/pull/619#issuecomment-288449915
MartinBasti
2017-03-27 11:54:18 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/619
Title: #619: pytest 3.x compatibility

Label: +ack
pvomacka
2017-03-27 16:04:14 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/619
Title: #619: pytest 3.x compatibility

Label: +pushed
pvomacka
2017-03-27 16:04:18 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/619
Title: #619: pytest 3.x compatibility

pvomacka commented:
"""
master:

* dd6b72e418eba01cc9eb9a7305291bf141b9eadf pytest 3.x compatibility
"""

See the full comment at https://github.com/freeipa/freeipa/pull/619#issuecomment-289500363
pvomacka
2017-03-27 16:04:21 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/619
Author: tiran
Title: #619: pytest 3.x compatibility
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/619/head:pr619
git checkout pr619

Loading...