Discussion:
[Freeipa-devel] [freeipa PR#266][opened] ipapython: simplify Env object initialization
jcholast
2016-11-23 12:43:01 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/266
Author: jcholast
Title: #266: ipapython: simplify Env object initialization
Action: opened

PR body:
"""
Fully initialize Env objects in Env() instead of having to call their
private methods to complete the initialization later.

Do not use custom Env instance to determine the debug level to use for the
IPA API object - the IPA API object can properly determining the
configured debug level on its own.

Remove locking and related code from Env as it is never used.

https://fedorahosted.org/freeipa/ticket/6408
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/266/head:pr266
git checkout pr266
jcholast
2016-11-23 13:04:37 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/266
Title: #266: ipapython: simplify Env object initialization

jcholast commented:
"""
Only now I have noticed that this won't actually help fixing [ticket 6482](https://fedorahosted.org/freeipa/ticket/6482).

Nevermind this PR then.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/266#issuecomment-262507414
jcholast
2016-11-23 13:04:45 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/266
Author: jcholast
Title: #266: ipapython: simplify Env object initialization
Action: edited

Changed field: body
Original value:
"""
Fully initialize Env objects in Env() instead of having to call their
private methods to complete the initialization later.

Do not use custom Env instance to determine the debug level to use for the
IPA API object - the IPA API object can properly determining the
configured debug level on its own.

Remove locking and related code from Env as it is never used.

https://fedorahosted.org/freeipa/ticket/6408
"""
pvoborni
2016-11-25 16:28:29 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/266
Title: #266: ipapython: simplify Env object initialization

pvoborni commented:
"""
I don't understand the "Nevermind this PR then.".

fixing ticket 6482 is good but fixing ticket 6408 is required event more for @tiran work, right?
"""

See the full comment at https://github.com/freeipa/freeipa/pull/266#issuecomment-262991677
stlaz
2016-11-29 08:09:38 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/266
Title: #266: ipapython: simplify Env object initialization

stlaz commented:
"""
From offline discussion I got that the PR should actually work in the end. I'll make the review.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/266#issuecomment-263503377
jcholast
2016-11-29 08:20:04 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/266
Title: #266: ipapython: simplify Env object initialization

jcholast commented:
"""
Yes, my above comment is wrong (sorry).
"""

See the full comment at https://github.com/freeipa/freeipa/pull/266#issuecomment-263505232
jcholast
2016-11-29 08:20:23 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/266
Author: jcholast
Title: #266: ipapython: simplify Env object initialization
Action: edited

Changed field: body
Original value:
"""
Fully initialize Env objects in Env() instead of having to call their
private methods to complete the initialization later.

Do not use custom Env instance to determine the debug level to use for the
IPA API object - the IPA API object can properly determining the
configured debug level on its own.

Remove locking and related code from Env as it is never used.
"""
stlaz
2016-11-29 10:23:03 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/266
Title: #266: ipapython: simplify Env object initialization

stlaz commented:
"""
This PR breaks almost all tests in test_ipalib/test_crud.py with `AttributeError: 'API' object has no attribute 'env'`. This error can be observed in some other tests:
http://pastebin.com/8EjE2QVS (please disregard the DNS tests failures).
"""

See the full comment at https://github.com/freeipa/freeipa/pull/266#issuecomment-263532334
HonzaCholasta
2017-01-17 08:30:35 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/266
Author: HonzaCholasta
Title: #266: ipapython: simplify Env object initialization
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/266/head:pr266
git checkout pr266
martbab
2017-03-10 08:30:44 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/266
Title: #266: ipapython: simplify Env object initialization

martbab commented:
"""
@stlaz @HonzaCholasta any progress on this PR or should we mark it as postponed and return to it later?
"""

See the full comment at https://github.com/freeipa/freeipa/pull/266#issuecomment-285608522
HonzaCholasta
2017-03-10 09:23:59 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/266
Title: #266: ipapython: simplify Env object initialization

Label: +postponed
HonzaCholasta
2017-03-20 10:47:56 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/266
Author: HonzaCholasta
Title: #266: ipapython: simplify Env object initialization
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/266/head:pr266
git checkout pr266
MartinBasti
2017-03-20 11:12:02 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/266
Title: #266: ipapython: simplify Env object initialization

Label: +rejected

Loading...