Discussion:
[Freeipa-devel] [freeipa PR#785][opened] otptoken-add-yubikey: When --digits not provided use default value
dkupka
2017-05-12 15:31:55 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/785
Author: dkupka
Title: #785: otptoken-add-yubikey: When --digits not provided use default value
Action: opened

PR body:
"""
Since Thin client was introduced default values for options are not populated
in client side plugins. When option has default value and is needed in client
plugin it must be handled by explicitly.

https://pagure.io/freeipa/issue/6900
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/785/head:pr785
git checkout pr785
stlaz
2017-05-16 08:11:30 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/785
Title: #785: otptoken-add-yubikey: When --digits not provided use default value

stlaz commented:
"""
Works for me.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/785#issuecomment-301708499
stlaz
2017-05-16 08:11:34 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/785
Title: #785: otptoken-add-yubikey: When --digits not provided use default value

Label: +ack
MartinBasti
2017-05-16 09:52:07 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/785
Title: #785: otptoken-add-yubikey: When --digits not provided use default value

MartinBasti commented:
"""
ipa-4-5:

* 749fc90d1fde0d012acb05ba64309f4a6ed63124 otptoken-add-yubikey: When --digits not provided use default value


master:

* e415da22f350fbda5b8b341bf2dc5f969cecb84a otptoken-add-yubikey: When --digits not provided use default value


"""

See the full comment at https://github.com/freeipa/freeipa/pull/785#issuecomment-301732673
MartinBasti
2017-05-16 09:52:12 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/785
Title: #785: otptoken-add-yubikey: When --digits not provided use default value

Label: +pushed
MartinBasti
2017-05-16 09:52:15 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/785
Author: dkupka
Title: #785: otptoken-add-yubikey: When --digits not provided use default value
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/785/head:pr785
git checkout pr785

Loading...