Discussion:
[Freeipa-devel] [freeipa PR#665][opened] Allow erasing ipaDomainResolutionOrder attribute
fidencio
2017-03-28 15:47:31 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/665
Author: fidencio
Title: #665: Allow erasing ipaDomainResolutionOrder attribute
Action: opened

PR body:
"""
Currently when trying to erase the ipaDomainResolutionOrder attribute we
hit an internal error as the split() method is called on a None object.

By returning early in case of empty string we now allow removing the
ipaDomainResolutionOrder attribute by both doing calling delattr or
setting its value to an empty string.

https://pagure.io/freeipa/issue/6825

Signed-off-by: Fabiano Fidêncio <***@redhat.com>
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/665/head:pr665
git checkout pr665
fidencio
2017-03-28 15:50:55 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/665
Author: fidencio
Title: #665: Allow erasing ipaDomainResolutionOrder attribute
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/665/head:pr665
git checkout pr665
MartinBasti
2017-03-28 15:57:34 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/665
Title: #665: Allow erasing ipaDomainResolutionOrder attribute

MartinBasti commented:
"""
LGTM
"""

See the full comment at https://github.com/freeipa/freeipa/pull/665#issuecomment-289817220
fidencio
2017-03-28 18:25:28 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/665
Author: fidencio
Title: #665: Allow erasing ipaDomainResolutionOrder attribute
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/665/head:pr665
git checkout pr665
fidencio
2017-03-28 18:26:07 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/665
Title: #665: Allow erasing ipaDomainResolutionOrder attribute

fidencio commented:
"""
I have updated the commit message as I found a typo there: "both doing calling delattr or" -> "both calling delattr or"
"""

See the full comment at https://github.com/freeipa/freeipa/pull/665#issuecomment-289861109
MartinBasti
2017-03-30 10:39:40 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/665
Title: #665: Allow erasing ipaDomainResolutionOrder attribute

Label: +ack
MartinBasti
2017-03-30 11:19:36 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/665
Title: #665: Allow erasing ipaDomainResolutionOrder attribute

MartinBasti commented:
"""
master:

* e03056cf34de5ba0100d62f008d76e8c851c3ba7 Allow erasing ipaDomainResolutionOrder attribute


ipa-4-5:

* 08a921cc08b5b841260caa2e45653a704b88542c Allow erasing ipaDomainResolutionOrder attribute


"""

See the full comment at https://github.com/freeipa/freeipa/pull/665#issuecomment-290381418
MartinBasti
2017-03-30 11:19:40 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/665
Author: fidencio
Title: #665: Allow erasing ipaDomainResolutionOrder attribute
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/665/head:pr665
git checkout pr665
MartinBasti
2017-03-30 11:19:43 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/665
Title: #665: Allow erasing ipaDomainResolutionOrder attribute

Label: +pushed

Loading...