[Freeipa-devel] [freeipa PR#783][opened] Provide useful messages during cert verification

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/783
Author: stlaz
Title: #783: Provide useful messages during cert verification
Action: opened

PR body:
"""
When the certificate verification was replaced, some error messages
were omitted (like "Peer's certificate expired."). Bring these back.
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/783/head:pr783
git checkout pr783

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/783
Author: stlaz
Title: #783: Provide useful messages during cert verification
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/783/head:pr783
git checkout pr783

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/783
Author: stlaz
Title: #783: Provide useful messages during cert verification
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/783/head:pr783
git checkout pr783

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/783
Author: stlaz
Title: #783: Provide useful messages during cert verification
Action: edited

Changed field: title
Original value:
"""
Provide useful messages during cert verification
"""

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/783
Author: stlaz
Title: #783: Provide useful messages during cert validation
Action: edited

Changed field: body
Original value:
"""
When the certificate verification was replaced, some error messages
were omitted (like "Peer's certificate expired."). Bring these back.
"""

[stlaz]

URL: https://github.com/freeipa/freeipa/pull/783
Author: stlaz
Title: #783: Provide useful messages during cert validation
Action: edited

Changed field: body
Original value:
"""
When the certificate validation was replaced, some error messages
were omitted (like "Peer's certificate expired."). Bring these back.
"""

[flo-renaud]

URL: https://github.com/freeipa/freeipa/pull/783
Title: #783: Provide useful messages during cert validation

flo-renaud commented:
"""
Hi @stlaz
Thank you for the patch. LGTM.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/783#issuecomment-301722760

[flo-renaud]

URL: https://github.com/freeipa/freeipa/pull/783
Title: #783: Provide useful messages during cert validation

Label: +ack

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/783
Title: #783: Provide useful messages during cert validation

MartinBasti commented:
"""
Please provide PR for `ipa-4-5` branch
"""

See the full comment at https://github.com/freeipa/freeipa/pull/783#issuecomment-302441669

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/783
Title: #783: Provide useful messages during cert validation

Label: +pushed

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/783
Title: #783: Provide useful messages during cert validation

MartinBasti commented:
"""
master:

* 3d969d7bad06e4f9527c88106806c28b68bfcc20 Provide useful messages during cert validation


"""

See the full comment at https://github.com/freeipa/freeipa/pull/783#issuecomment-302441982

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/783
Author: stlaz
Title: #783: Provide useful messages during cert validation
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/783/head:pr783
git checkout pr783

[MartinBasti]

URL: https://github.com/freeipa/freeipa/pull/783
Title: #783: Provide useful messages during cert validation

MartinBasti commented:
"""
No need for `ipa-4-5` this regression is not in 4.5, master only
"""

See the full comment at https://github.com/freeipa/freeipa/pull/783#issuecomment-302447377