Discussion:
[Freeipa-devel] [freeipa PR#572][opened] rpc: fix crash in verbose mode
HonzaCholasta
2017-03-13 09:25:34 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/572
Author: HonzaCholasta
Title: #572: rpc: fix crash in verbose mode
Action: opened

PR body:
"""
Fix a crash caused by feeding incorrect data to `json.dumps()` in
`JSONServerProxy.__request()` introduced by commit
8159c2883bf66980582d1227c364df4e592bdd7e.

https://pagure.io/freeipa/issue/6655
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/572/head:pr572
git checkout pr572
stlaz
2017-03-13 09:34:17 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/572
Title: #572: rpc: fix crash in verbose mode

stlaz commented:
"""
Does this fix https://pagure.io/freeipa/issue/6734?
"""

See the full comment at https://github.com/freeipa/freeipa/pull/572#issuecomment-286056640
HonzaCholasta
2017-03-13 09:41:01 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/572
Title: #572: rpc: fix crash in verbose mode

HonzaCholasta commented:
"""
Yes.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/572#issuecomment-286058220
HonzaCholasta
2017-03-13 09:41:22 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/572
Author: HonzaCholasta
Title: #572: rpc: fix crash in verbose mode
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/572/head:pr572
git checkout pr572
stlaz
2017-03-13 14:34:06 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/572
Title: #572: rpc: fix crash in verbose mode

Label: +ack
stlaz
2017-03-13 14:34:01 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/572
Title: #572: rpc: fix crash in verbose mode

stlaz commented:
"""
Works for me.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/572#issuecomment-286125002
MartinBasti
2017-03-13 14:45:53 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/572
Title: #572: rpc: fix crash in verbose mode

MartinBasti commented:
"""
master:

* 8295848bfec6f96410ab8383107fdaf565f02974 rpc: fix crash in verbose mode
"""

See the full comment at https://github.com/freeipa/freeipa/pull/572#issuecomment-286128713
MartinBasti
2017-03-13 14:46:00 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/572
Title: #572: rpc: fix crash in verbose mode

Label: +pushed
MartinBasti
2017-03-13 14:46:07 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/572
Author: HonzaCholasta
Title: #572: rpc: fix crash in verbose mode
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/572/head:pr572
git checkout pr572

Loading...