Discussion:
[Freeipa-devel] [freeipa PR#712][opened] WebUI: Coverity fixes
pvomacka
2017-04-13 12:43:02 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/712
Author: pvomacka
Title: #712: WebUI: Coverity fixes
Action: opened

PR body:
"""
Several fixes:

- null pointer exception
- add explicit object
- removes identical branches of if statement

"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/712/head:pr712
git checkout pr712
tomaskrizek
2017-04-24 09:54:59 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/712
Title: #712: WebUI: Coverity fixes

Label: +ack
MartinBasti
2017-04-25 10:23:37 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/712
Title: #712: WebUI: Coverity fixes

Label: +pushed
MartinBasti
2017-04-25 10:23:41 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/712
Title: #712: WebUI: Coverity fixes

MartinBasti commented:
"""
master:

* b54ceae9616b733c35ce7928309b8ab93527110b WebUI: Coverity - add explicit window object to alert methods
* 5ba7957450ebe78c67cf675855f4f4c3a34fab54 WebUI - Coverity: fixed null pointer exception
* 01516e58c8fc71985c538136b2286198765da296 WebUI - Coverity: fix identical branches of if statement


"""

See the full comment at https://github.com/freeipa/freeipa/pull/712#issuecomment-296987672
MartinBasti
2017-04-25 10:23:44 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/712
Author: pvomacka
Title: #712: WebUI: Coverity fixes
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/712/head:pr712
git checkout pr712

Loading...