stlaz
2017-05-18 07:57:47 UTC
URL: https://github.com/freeipa/freeipa/pull/769
Title: #769: test_caless: add pkinit option and test it
stlaz commented:
"""
The changes are fine. Please note the licence at the original file which you're copying here:
```bash
#!/bin/bash -e
#
# Copyright (c) 2015, Jan Cholasta <***@redhat.com>
#
# Permission to use, copy, modify, and/or distribute this software for any
# purpose with or without fee is hereby granted, provided that the above
# copyright notice and this permission notice appear in all copies.
#
# THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
# WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
# MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
# ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
# WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
# ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
# OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
```
I don't want to appear amid some multi-licence hell, so I suppose you should add at least the common header for FreeIPA files:
```
#
# Copyright (C) 2017 FreeIPA Contributors see COPYING for license
#
```
with the kind permission of @HonzaCholasta.
"""
See the full comment at https://github.com/freeipa/freeipa/pull/769#issuecomment-302330229
Title: #769: test_caless: add pkinit option and test it
stlaz commented:
"""
The changes are fine. Please note the licence at the original file which you're copying here:
```bash
#!/bin/bash -e
#
# Copyright (c) 2015, Jan Cholasta <***@redhat.com>
#
# Permission to use, copy, modify, and/or distribute this software for any
# purpose with or without fee is hereby granted, provided that the above
# copyright notice and this permission notice appear in all copies.
#
# THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
# WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
# MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
# ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
# WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
# ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
# OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
```
I don't want to appear amid some multi-licence hell, so I suppose you should add at least the common header for FreeIPA files:
```
#
# Copyright (C) 2017 FreeIPA Contributors see COPYING for license
#
```
with the kind permission of @HonzaCholasta.
"""
See the full comment at https://github.com/freeipa/freeipa/pull/769#issuecomment-302330229