Discussion:
[Freeipa-devel] [freeipa PR#545][opened] install_check: require IPv6 stack to be enabled
tomaskrizek
2017-03-07 13:07:13 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/545
Author: tomaskrizek
Title: #545: install_check: require IPv6 stack to be enabled
Action: opened

PR body:
"""
Add checks to install and replica install to verify IPv6 stack
is enabled. IPv6 is required by some IPA parts (AD, conncheck, ...).

https://pagure.io/freeipa/issue/6608
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/545/head:pr545
git checkout pr545
tomaskrizek
2017-03-07 13:16:49 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/545
Author: tomaskrizek
Title: #545: install_check: require IPv6 stack to be enabled
Action: edited

Changed field: body
Original value:
"""
Add checks to install and replica install to verify IPv6 stack
is enabled. IPv6 is required by some IPA parts (AD, conncheck, ...).

https://pagure.io/freeipa/issue/6608
"""
tomaskrizek
2017-03-07 14:18:28 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/545
Author: tomaskrizek
Title: #545: install_check: require IPv6 stack to be enabled
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/545/head:pr545
git checkout pr545
abbra
2017-03-07 14:35:50 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/545
Title: #545: install_check: require IPv6 stack to be enabled

abbra commented:
"""
how the /proc check going to play with containers?
"""

See the full comment at https://github.com/freeipa/freeipa/pull/545#issuecomment-284738343
tomaskrizek
2017-03-07 15:20:06 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/545
Title: #545: install_check: require IPv6 stack to be enabled

tomaskrizek commented:
"""
We tested it with @MartinBasti and `/proc` is mounted in container.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/545#issuecomment-284751484
HonzaCholasta
2017-03-08 08:41:38 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/545
Title: #545: install_check: require IPv6 stack to be enabled

HonzaCholasta commented:
"""
Nitpick: the "install_check" prefix in the subject does not say anything, there are currently 7 `install_check`s in IPA. Please use something more descriptive, such as "server install".
"""

See the full comment at https://github.com/freeipa/freeipa/pull/545#issuecomment-284980994
tomaskrizek
2017-03-08 09:08:49 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/545
Author: tomaskrizek
Title: #545: install_check: require IPv6 stack to be enabled
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/545/head:pr545
git checkout pr545
MartinBasti
2017-03-09 13:41:46 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/545
Title: #545: install_check: require IPv6 stack to be enabled

Label: +ack
tomaskrizek
2017-03-09 15:51:35 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/545
Title: #545: install_check: require IPv6 stack to be enabled

Label: +pushed
tomaskrizek
2017-03-09 15:51:37 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/545
Author: tomaskrizek
Title: #545: install_check: require IPv6 stack to be enabled
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/545/head:pr545
git checkout pr545
tomaskrizek
2017-03-09 15:51:36 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/545
Title: #545: install_check: require IPv6 stack to be enabled

tomaskrizek commented:
"""
master:

* ecb450308d0a49afffb31dda1e405ad40552e70e server install: require IPv6 stack to be enabled
"""

See the full comment at https://github.com/freeipa/freeipa/pull/545#issuecomment-285390484
tomaskrizek
2017-03-09 15:53:24 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/545
Title: #545: install_check: require IPv6 stack to be enabled

tomaskrizek commented:
"""
I had to rebase for `ipa-4-4`: #562
"""

See the full comment at https://github.com/freeipa/freeipa/pull/545#issuecomment-285391132
Loading...