Discussion:
[Freeipa-devel] [freeipa PR#736][opened] Fixing the cert-request command comparing whole email address case-sensitively.
felipevolpone
2017-04-26 14:12:02 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/736
Author: felipevolpone
Title: #736: Fixing the cert-request command comparing whole email address case-sensitively.
Action: opened

PR body:
"""
Now, the cert-request command compares the domain part of the email case-insensitively.

Fixes: [https://pagure.io/freeipa/issue/5919](https://pagure.io/freeipa/issue/5919)
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/736/head:pr736
git checkout pr736
felipevolpone
2017-05-02 15:30:34 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/736
Author: felipevolpone
Title: #736: Fixing the cert-request command comparing whole email address case-sensitively.
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/736/head:pr736
git checkout pr736
felipevolpone
2017-05-02 15:42:20 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/736
Title: #736: Fixing the cert-request command comparing whole email address case-sensitively.

felipevolpone commented:
"""
@frasertweedale I did the check in SAN extension.

However, I'm not sure if these are valid situations:
Case 1)
The principal email is ***@email.com
The email in the certificate is ***@email.com
The emails in the SAN extensions are: ***@email.com, ***@email.com

or this:

Case 2)
The principal email is ***@email.com
The email in the certificate is ***@email.com, ***@email.com
The email in the SAN extensions is: ***@email.com

If the case 1 is valid, the check in line 799 (below) is not right, because it expects that all emails in SAN extension are in the principal.
```python
elif isinstance(gn, cryptography.x509.general_name.RFC822Name):
if principal_type == USER:
if principal_obj and gn.value not in principal_obj.get(
'mail', []):
raise errors.ValidationError(
name='csr',
error=_(
"RFC822Name does not match "
"any of user's email addresses")
)
else:
raise errors.ValidationError(
name='csr',
error=_(
"subject alt name type %s is forbidden "
"for non-user principals") % "RFC822Name"
```
"""

See the full comment at https://github.com/freeipa/freeipa/pull/736#issuecomment-298673966
felipevolpone
2017-05-02 15:45:07 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/736
Author: felipevolpone
Title: #736: Fixing the cert-request command comparing whole email address case-sensitively.
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/736/head:pr736
git checkout pr736
felipevolpone
2017-05-03 17:28:50 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/736
Author: felipevolpone
Title: #736: Fixing the cert-request command comparing whole email address case-sensitively.
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/736/head:pr736
git checkout pr736
felipevolpone
2017-05-03 19:30:36 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/736
Author: felipevolpone
Title: #736: Fixing the cert-request command comparing whole email address case-sensitively.
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/736/head:pr736
git checkout pr736
felipevolpone
2017-05-03 20:08:18 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/736
Author: felipevolpone
Title: #736: Fixing the cert-request command comparing whole email address case-sensitively.
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/736/head:pr736
git checkout pr736
felipevolpone
2017-05-04 20:12:02 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/736
Author: felipevolpone
Title: #736: Fixing the cert-request command comparing whole email address case-sensitively.
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/736/head:pr736
git checkout pr736
felipevolpone
2017-05-04 20:17:23 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/736
Title: #736: Fixing the cert-request command comparing whole email address case-sensitively.

felipevolpone commented:
"""
I hope it's fine now
"""

See the full comment at https://github.com/freeipa/freeipa/pull/736#issuecomment-299296983
felipevolpone
2017-05-05 13:55:26 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/736
Author: felipevolpone
Title: #736: Fixing the cert-request command comparing whole email address case-sensitively.
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/736/head:pr736
git checkout pr736
felipevolpone
2017-05-05 14:25:30 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/736
Author: felipevolpone
Title: #736: Fixing the cert-request command comparing whole email address case-sensitively.
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/736/head:pr736
git checkout pr736
felipevolpone
2017-05-05 15:17:36 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/736
Author: felipevolpone
Title: #736: Fixing the cert-request command comparing whole email address case-sensitively.
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/736/head:pr736
git checkout pr736
felipevolpone
2017-05-10 13:21:35 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/736
Author: felipevolpone
Title: #736: Fixing the cert-request command comparing whole email address case-sensitively.
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/736/head:pr736
git checkout pr736
felipevolpone
2017-05-10 13:34:02 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/736
Author: felipevolpone
Title: #736: Fixing the cert-request command comparing whole email address case-sensitively.
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/736/head:pr736
git checkout pr736
felipevolpone
2017-05-10 13:24:58 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/736
Author: felipevolpone
Title: #736: Fixing the cert-request command comparing whole email address case-sensitively.
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/736/head:pr736
git checkout pr736
felipevolpone
2017-05-11 13:20:53 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/736
Author: felipevolpone
Title: #736: Fixing the cert-request command comparing whole email address case-sensitively.
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/736/head:pr736
git checkout pr736
felipevolpone
2017-05-11 13:28:43 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/736
Title: #736: Fixing the cert-request command comparing whole email address case-sensitively.

felipevolpone commented:
"""
Done! Thank you Fraser :)) :+1:
"""

See the full comment at https://github.com/freeipa/freeipa/pull/736#issuecomment-300789100
frasertweedale
2017-05-15 00:20:30 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/736
Title: #736: Fixing the cert-request command comparing whole email address case-sensitively.

Label: +ack
MartinBasti
2017-05-16 08:14:57 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/736
Title: #736: Fixing the cert-request command comparing whole email address case-sensitively.

Label: +pushed
MartinBasti
2017-05-16 08:15:02 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/736
Title: #736: Fixing the cert-request command comparing whole email address case-sensitively.

MartinBasti commented:
"""
master:

* d973168e89c7fb5e8c36919b3adb685371e1a3ab Fixing the cert-request comparing whole email address case-sensitively.


"""

See the full comment at https://github.com/freeipa/freeipa/pull/736#issuecomment-301709267
MartinBasti
2017-05-16 08:15:08 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/736
Author: felipevolpone
Title: #736: Fixing the cert-request command comparing whole email address case-sensitively.
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/736/head:pr736
git checkout pr736

Loading...