Discussion:
[Freeipa-devel] [freeipa PR#800][opened] Change python-cryptography to python2-cryptography
pvomacka
2017-05-19 14:50:16 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/800
Author: pvomacka
Title: #800: Change python-cryptography to python2-cryptography
Action: opened

PR body:
"""
Package name is python2-cryptography and even that it Provides
python-cryptography package, it causes problems during update of IPA
on RHEL - python2-cryptography is not updated. After changing required package
name to python2-cryptography upgrade on RHEL works well.

Fixes: https://pagure.io/freeipa/issue/6749
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/800/head:pr800
git checkout pr800
martbab
2017-05-19 15:13:04 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/800
Title: #800: Change python-cryptography to python2-cryptography

martbab commented:
"""
Shouldn't this be a downstream-only patch, given that it affects only RHEL while Fedora resolves the dependencies correctly?
"""

See the full comment at https://github.com/freeipa/freeipa/pull/800#issuecomment-302730052
pvoborni
2017-05-19 15:33:13 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/800
Title: #800: Change python-cryptography to python2-cryptography

pvoborni commented:
"""
Bumping the dep upstream later without this change have potential to introduce the bug again in downstream if one is not careful. This will also unify the usages as ipatests package uses python2-cryptography already.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/800#issuecomment-302735641
MartinBasti
2017-05-22 11:45:30 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/800
Title: #800: Change python-cryptography to python2-cryptography

MartinBasti commented:
"""
Voting for explicit `python2-*` prefix
"""

See the full comment at https://github.com/freeipa/freeipa/pull/800#issuecomment-303077114
martbab
2017-05-22 13:40:20 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/800
Title: #800: Change python-cryptography to python2-cryptography

martbab commented:
"""
@pvoborni thank you for explanation I am OK with this change then.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/800#issuecomment-303103024
Loading...