Discussion:
[Freeipa-devel] [freeipa PR#751][opened] ipa-client-install: remove extra space in pkinit_anchors definition
flo-renaud
2017-05-02 08:29:22 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/751
Author: flo-renaud
Title: #751: ipa-client-install: remove extra space in pkinit_anchors definition
Action: opened

PR body:
"""
ipa-client-install modifies /etc/krb5.conf and defines the following line:
pkinit_anchors = FILE: /etc/ipa/ca.crt

The extra space between FILE: and /etc/ipa/ca.crt break pkinit.

https://pagure.io/freeipa/issue/6916
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/751/head:pr751
git checkout pr751
abbra
2017-05-02 10:01:14 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/751
Title: #751: ipa-client-install: remove extra space in pkinit_anchors definition

abbra commented:
"""
LGTM.

For the record, this is broken since cf1c4e84e74ea15fe5cf7219872cf131bd53281e which is in 4.5.0 release. So we need to backport this to 4.5 branch.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/751#issuecomment-298587034
abbra
2017-05-02 10:01:32 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/751
Title: #751: ipa-client-install: remove extra space in pkinit_anchors definition

Label: +ack
MartinBasti
2017-05-02 11:47:34 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/751
Title: #751: ipa-client-install: remove extra space in pkinit_anchors definition

Label: +pushed
MartinBasti
2017-05-02 11:47:38 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/751
Title: #751: ipa-client-install: remove extra space in pkinit_anchors definition

MartinBasti commented:
"""
master:

* 26dbab1fd4384b8f3999b153c2d94220cf541ad2 ipa-client-install: remove extra space in pkinit_anchors definition


ipa-4-5:

* a3c4e70650dbcd5dd3f00a7b2fecc051afeebec0 ipa-client-install: remove extra space in pkinit_anchors definition


"""

See the full comment at https://github.com/freeipa/freeipa/pull/751#issuecomment-298613205
MartinBasti
2017-05-02 11:47:41 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/751
Author: flo-renaud
Title: #751: ipa-client-install: remove extra space in pkinit_anchors definition
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/751/head:pr751
git checkout pr751

Loading...