Discussion:
[Freeipa-devel] [freeipa PR#639][opened] WebUI: Login for AD Users
pvomacka
2017-03-22 16:22:20 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/639
Author: pvomacka
Title: #639: WebUI: Login for AD Users
Action: opened

PR body:
"""
Allows login as AD user. AD Users has its own menu specification as there is visible only its profile and list of active IPA users.

https://pagure.io/freeipa/issue/3242
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/639/head:pr639
git checkout pr639
pvomacka
2017-03-22 16:49:54 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/639
Author: pvomacka
Title: #639: WebUI: Login for AD Users
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/639/head:pr639
git checkout pr639
pvomacka
2017-03-23 12:43:36 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/639
Author: pvomacka
Title: #639: WebUI: Login for AD Users
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/639/head:pr639
git checkout pr639
pvomacka
2017-03-23 14:53:10 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/639
Author: pvomacka
Title: #639: WebUI: Login for AD Users
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/639/head:pr639
git checkout pr639
pvomacka
2017-03-23 14:54:51 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/639
Title: #639: WebUI: Login for AD Users

pvomacka commented:
"""
I implemented all comments which you proposed and I also changed menu of AD user selfservice - I removed User tab and renamed User ID override to Profile.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/639#issuecomment-288744985
abbra
2017-03-24 07:57:48 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/639
Title: #639: WebUI: Login for AD Users

abbra commented:
"""
LGTM and works just fine: ![](Loading Image...)
"""

See the full comment at https://github.com/freeipa/freeipa/pull/639#issuecomment-288956595
pvoborni
2017-03-24 08:27:22 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/639
Title: #639: WebUI: Login for AD Users

pvoborni commented:
"""
The code changes looks good to me. ACK given that it works fine (@abbra 's comment).
"""

See the full comment at https://github.com/freeipa/freeipa/pull/639#issuecomment-288961590
pvoborni
2017-03-24 08:27:34 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/639
Title: #639: WebUI: Login for AD Users

Label: +ack
martbab
2017-03-27 06:56:22 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/639
Author: pvomacka
Title: #639: WebUI: Login for AD Users
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/639/head:pr639
git checkout pr639
martbab
2017-03-27 06:56:15 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/639
Title: #639: WebUI: Login for AD Users

Label: +pushed
martbab
2017-03-27 06:56:19 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/639
Title: #639: WebUI: Login for AD Users

martbab commented:
"""
master:

* 1dcdcd12f4336c98e7507fe0e7f0c0da2bc69eba WebUI: check principals in lowercase
* 2992e3c5d480567cfdc71b38365d5d74f009b4d2 WebUI: add method for disabling item in user dropdown menu
* ceedc3f7ecb1300ed5bfaf5db8ef1b1450c6288e WebUI: Add support for login for AD users
ipa-4-5:

* bee9c9f090e7808a2381054fa63c1d036743296c WebUI: check principals in lowercase
* 01a0a38bdf53821bc420f01dc98fae577f83eabb WebUI: add method for disabling item in user dropdown menu
* 228e039e7d718ced7dce7c32cca3a89404c0a16e WebUI: Add support for login for AD users
"""

See the full comment at https://github.com/freeipa/freeipa/pull/639#issuecomment-289369118
Loading...