Discussion:
[Freeipa-devel] [freeipa PR#470][opened] WebUI: Size limit warning on details pages fixed
pvomacka
2017-02-15 11:31:52 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/470
Author: pvomacka
Title: #470: WebUI: Size limit warning on details pages fixed
Action: opened

PR body:
"""
Entity select fields accepted globally set size limit and in situations when
there were more entries than global size limit allows then the "Truncated" warning
shows up. Also only subset of items was shown.
All entity select widgets now uses find methods with sizelimit set to 0
which says get all entries.

This setting is configurable using search_all_entries attribute.

https://fedorahosted.org/freeipa/ticket/6618
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/470/head:pr470
git checkout pr470
pvoborni
2017-02-17 11:37:54 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/470
Title: #470: WebUI: Size limit warning on details pages fixed

pvoborni commented:
"""
Would it be better to suppress the warning and use sensible size limit. I.e. the entity select doesn't need to show all entries. I'm afraid that it might have negative performance impact.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/470#issuecomment-280627755
pvomacka
2017-03-17 14:22:35 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/470
Author: pvomacka
Title: #470: WebUI: Size limit warning on details pages fixed
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/470/head:pr470
git checkout pr470
pvomacka
2017-03-23 15:23:41 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/470
Author: pvomacka
Title: #470: WebUI: Size limit warning on details pages fixed
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/470/head:pr470
git checkout pr470
pvoborni
2017-03-24 08:48:18 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/470
Title: #470: WebUI: Size limit warning on details pages fixed

Label: +ack
pvoborni
2017-03-24 08:48:23 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/470
Title: #470: WebUI: Size limit warning on details pages fixed

pvoborni commented:
"""
Code looks good and works fine, ACK.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/470#issuecomment-288965483
pvomacka
2017-03-27 16:10:49 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/470
Title: #470: WebUI: Size limit warning on details pages fixed

Label: +pushed
pvomacka
2017-03-27 16:10:54 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/470
Title: #470: WebUI: Size limit warning on details pages fixed

pvomacka commented:
"""
ipa-4-5:

* 422c9058d9a6be69db4eab7db654b9184ae5eab6 WebUI: Add support for suppressing warnings
* 697a5779b377a5d76c1cb212514b6feb46326f71 WebUI: suppress truncation warning in select widget
master:

* 7b3a10da7001d7ee394cd891d926def66d0f2546 WebUI: Add support for suppressing warnings
* b9e6ad1967ba24c7ebe5181da1ebe32d30e7b28f WebUI: suppress truncation warning in select widget
"""

See the full comment at https://github.com/freeipa/freeipa/pull/470#issuecomment-289502331
pvomacka
2017-03-27 16:10:55 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/470
Author: pvomacka
Title: #470: WebUI: Size limit warning on details pages fixed
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/470/head:pr470
git checkout pr470

Loading...