Discussion:
[Freeipa-devel] [freeipa PR#353][opened] [RFE] Pwdpolicy
simo5
2016-12-19 15:05:23 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/353
Author: simo5
Title: #353: [RFE] Pwdpolicy
Action: opened

PR body:
"""
Untested but I am seeking feedback on the actual approach.
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/353/head:pr353
git checkout pr353
martbab
2017-01-24 09:21:27 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/353
Title: #353: [RFE] Pwdpolicy

martbab commented:
"""
LGTM, but the PR needs some more love since it breaks CI.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/353#issuecomment-274750406
simo5
2017-01-25 12:50:32 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/353
Author: simo5
Title: #353: [RFE] Pwdpolicy
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/353/head:pr353
git checkout pr353
simo5
2017-01-25 13:23:23 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/353
Title: #353: [RFE] Pwdpolicy

simo5 commented:
"""
I found two subtle bugs that cause the install failure, with the rebased patches install completes correctly for me.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/353#issuecomment-275106444
martbab
2017-03-10 08:16:52 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/353
Title: #353: [RFE] Pwdpolicy

martbab commented:
"""
test_kadmin and all other tests also passed. I do not see reason for not pushing. Sorry for the dealy in reviewing.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/353#issuecomment-285605908
martbab
2017-03-10 08:16:53 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/353
Title: #353: [RFE] Pwdpolicy

Label: +ack
martbab
2017-03-10 08:17:44 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/353
Title: #353: [RFE] Pwdpolicy

martbab commented:
"""
test_kadmin and all other tests also passed. I do not see reason for not pushing. Sorry for the dealy in reviewing.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/353#issuecomment-285605908
martbab
2017-03-10 08:18:02 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/353
Author: simo5
Title: #353: [RFE] Pwdpolicy
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/353/head:pr353
git checkout pr353
martbab
2017-03-10 08:18:00 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/353
Title: #353: [RFE] Pwdpolicy

martbab commented:
"""
master:

* 9f13b330aaec468a018472dce5fc77131277de94 Add code to retrieve results from multiple bases
* 2e5cc369fd8b9d780697a9a286429cc2ca0f448a Add support for searching policies in cn=accounts
"""

See the full comment at https://github.com/freeipa/freeipa/pull/353#issuecomment-285606111
martbab
2017-03-10 08:17:59 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/353
Title: #353: [RFE] Pwdpolicy

Label: +pushed

Loading...