Discussion:
[Freeipa-devel] [freeipa PR#657][opened] configure: fix --disable-server with certauth plugin
sumit-bose
2017-03-27 10:21:31 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/657
Author: sumit-bose
Title: #657: configure: fix --disable-server with certauth plugin
Action: opened

PR body:
"""
Resolves https://pagure.io/freeipa/issue/6816
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/657/head:pr657
git checkout pr657
sumit-bose
2017-03-27 10:37:09 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/657
Author: sumit-bose
Title: #657: configure: fix --disable-server with certauth plugin
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/657/head:pr657
git checkout pr657
lslebodn
2017-03-27 10:43:21 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/657
Title: #657: configure: fix --disable-server with certauth plugin

lslebodn commented:
"""
`AM_CONDITIONAL` need to be executed every time.

So just `AM_CONDITIONAL([BUILD_IPA_CERTAUTH_PLUGIN]` need to be moved from sever.m4 -> configure.ac. The best would be to build somewhere after `m4_include(server.m4)`
"""

See the full comment at https://github.com/freeipa/freeipa/pull/657#issuecomment-289417730
lslebodn
2017-03-27 10:43:49 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/657
Title: #657: configure: fix --disable-server with certauth plugin

lslebodn commented:
"""
`AM_CONDITIONAL` need to be executed every time.

So just `AM_CONDITIONAL([BUILD_IPA_CERTAUTH_PLUGIN]` need to be moved from sever.m4 -> configure.ac. The best would be to build somewhere after `m4_include(server.m4)`
"""

See the full comment at https://github.com/freeipa/freeipa/pull/657#issuecomment-289417730
sumit-bose
2017-03-27 11:22:14 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/657
Author: sumit-bose
Title: #657: configure: fix --disable-server with certauth plugin
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/657/head:pr657
git checkout pr657
tiran
2017-03-27 11:28:24 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/657
Title: #657: configure: fix --disable-server with certauth plugin

tiran commented:
"""
LGTM

I verified that the PR fixes

* --disable-server
* --enable-server with old version of krb5 that does not have ```krb5/certauth_plugin.h```
"""

See the full comment at https://github.com/freeipa/freeipa/pull/657#issuecomment-289426483
tiran
2017-03-27 11:57:07 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/657
Title: #657: configure: fix --disable-server with certauth plugin

Label: +ack
pvomacka
2017-03-27 15:58:14 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/657
Title: #657: configure: fix --disable-server with certauth plugin

pvomacka commented:
"""
ipa-4-5:

* 203d5416ce807f5cdcf9e2431feef84d49b3df61 configure: fix --disable-server with certauth plugin
* 8fde0b88d7c9360e16820d6086eba3e3ca0eee1e ipa-kdb: do not depend on certauth_plugin.h
master:

* 054f1bd78b04a79f765f524f829b34c0ee252a1b configure: fix --disable-server with certauth plugin
* 0ba0c0781367d8e2d4affca29e3cf5ab93c4c33a ipa-kdb: do not depend on certauth_plugin.h
"""

See the full comment at https://github.com/freeipa/freeipa/pull/657#issuecomment-289498536
pvomacka
2017-03-27 15:58:18 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/657
Title: #657: configure: fix --disable-server with certauth plugin

Label: +pushed
pvomacka
2017-03-27 15:58:22 UTC
Permalink
URL: https://github.com/freeipa/freeipa/pull/657
Author: sumit-bose
Title: #657: configure: fix --disable-server with certauth plugin
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/657/head:pr657
git checkout pr657

Loading...